From 065e801a08a937b01306eae7d969bfcad93be8af Mon Sep 17 00:00:00 2001 From: Neil Fraser Date: Thu, 24 Nov 2016 07:29:39 -0800 Subject: [PATCH] When user edits text in a field, set text, not value. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Existing text-editable fields don’t care (dropdown care, but are not text-editable). But a note picker needs to set its value to 60 if text is set to ‘C4’. --- core/field_textinput.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/field_textinput.js b/core/field_textinput.js index 3fe075819..4d588e72e 100644 --- a/core/field_textinput.js +++ b/core/field_textinput.js @@ -195,7 +195,7 @@ Blockly.FieldTextInput.prototype.onHtmlInputChange_ = function(e) { var text = htmlInput.value; if (text !== htmlInput.oldValue_) { htmlInput.oldValue_ = text; - this.setValue(text); + this.setText(text); this.validate_(); } else if (goog.userAgent.WEBKIT) { // Cursor key. Render the source block to show the caret moving.