CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-09 10:00:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: Fix exception when disposing of a workspace with a variable block obscuring a shadow block. (#8619)

Browse Source
This commit is contained in:
Aaron Dodson
2024-10-15 13:45:39 -07:00
committed by GitHub
parent aeb1a80672
commit 089179bb01
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/workspace.ts
View File

@@ -371,7 +371,14 @@ export class Workspace implements IASTNodeLocation {
this.topComments[this.topComments.length - 1].dispose();
}
eventUtils.setGroup(existingGroup);
this.variableMap.clear();
// If this is a flyout workspace, its variable map is shared with the
// parent workspace, so we either don't want to disturb it if we're just
// disposing the flyout, or if the flyout is being disposed because the
// main workspace is being disposed, then the main workspace will handle
// cleaning it up.
if (!this.isFlyout) {
this.variableMap.clear();
}
if (this.potentialVariableMap) {
this.potentialVariableMap.clear();
}