CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-08 01:20:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

chore: Use .includes and .startsWith, not .indexOf (#7936)

Browse Source 
Easier to read than the diverse collection of `=== 0` and `!== -1` and `> -1` tests.
This commit is contained in:
Neil Fraser
2024-03-15 00:03:55 +01:00
committed by GitHub
parent 81e2203f7f
commit 0ecbcde9fc
42 changed files with 62 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/mocha/test_helpers/user_input.js
View File

@@ -41,10 +41,10 @@ export function createKeyDownEvent(keyCode, modifiers) {
keyCode: keyCode,
};
if (modifiers && modifiers.length > 0) {
event.altKey = modifiers.indexOf(KeyCodes.ALT) > -1;
event.ctrlKey = modifiers.indexOf(KeyCodes.CTRL) > -1;
event.metaKey = modifiers.indexOf(KeyCodes.META) > -1;
event.shiftKey = modifiers.indexOf(KeyCodes.SHIFT) > -1;
event.altKey = modifiers.includes(KeyCodes.ALT);
event.ctrlKey = modifiers.includes(KeyCodes.CTRL);
event.metaKey = modifiers.includes(KeyCodes.META);
event.shiftKey = modifiers.includes(KeyCodes.SHIFT);
}
return new KeyboardEvent('keydown', event);
}