From 11f6c5a631f454e020b28fc151c15c31ef821bb3 Mon Sep 17 00:00:00 2001 From: Neil Fraser Date: Wed, 31 Jul 2019 15:52:13 -0700 Subject: [PATCH] Fix angle picker when 'Infinity' is typed in. Previously 'NaN' would be generated, which is not a legal value. --- core/field_angle.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/core/field_angle.js b/core/field_angle.js index 4f2da5ade..f4871ba7b 100644 --- a/core/field_angle.js +++ b/core/field_angle.js @@ -340,11 +340,10 @@ Blockly.FieldAngle.prototype.updateGraph_ = function() { * @override */ Blockly.FieldAngle.prototype.doClassValidation_ = function(opt_newValue) { - if (isNaN(opt_newValue)) { + var n = Number(opt_newValue) % 360; + if (isNaN(n)) { return null; } - var n = parseFloat(opt_newValue || 0); - n %= 360; if (n < 0) { n += 360; }