mirror of
https://github.com/google/blockly.git
synced 2025-12-15 22:00:07 +01:00
chore(generators): Fix nits (#7166)
Addresses various nits that escaped previous PRs: * Add TSDoc for `BlockGenerator` in `core/generator.ts` for PR #7150. * Fix bad formating in `generators/javascript.js` from PR #7153. * Add missing `@enum` tag that should have been included in PR #7160. * Delete obsolete comment from `generators/python.js` for PR #7163.
This commit is contained in:
committed by
GitHub
parent
438df8761d
commit
12b91ae49c
@@ -24,6 +24,7 @@ import {inputTypes} from '../core/inputs/input_types.js';
|
||||
/**
|
||||
* Order of operation ENUMs.
|
||||
* https://dart.dev/guides/language/language-tour#operators
|
||||
* @enum {number}
|
||||
*/
|
||||
export const Order = {
|
||||
ATOMIC: 0, // 0 "" ...
|
||||
|
||||
@@ -164,7 +164,8 @@ export class JavascriptGenerator extends CodeGenerator {
|
||||
// Add user variables, but only ones that are being used.
|
||||
const variables = Variables.allUsedVarModels(workspace);
|
||||
for (let i = 0; i < variables.length; i++) {
|
||||
defvars.push(this.nameDB_.getName(variables[i].getId(), NameType.VARIABLE));
|
||||
defvars.push(
|
||||
this.nameDB_.getName(variables[i].getId(), NameType.VARIABLE));
|
||||
}
|
||||
|
||||
// Declare all of the variables.
|
||||
@@ -236,7 +237,8 @@ export class JavascriptGenerator extends CodeGenerator {
|
||||
* Calls any statements following this block.
|
||||
* @param {!Block} block The current block.
|
||||
* @param {string} code The JavaScript code created for this block.
|
||||
* @param {boolean=} opt_thisOnly True to generate code for only this statement.
|
||||
* @param {boolean=} opt_thisOnly True to generate code for only this
|
||||
* statement.
|
||||
* @return {string} JavaScript code with comments and subsequent blocks added.
|
||||
* @protected
|
||||
*/
|
||||
@@ -264,7 +266,8 @@ export class JavascriptGenerator extends CodeGenerator {
|
||||
}
|
||||
}
|
||||
}
|
||||
const nextBlock = block.nextConnection && block.nextConnection.targetBlock();
|
||||
const nextBlock =
|
||||
block.nextConnection && block.nextConnection.targetBlock();
|
||||
const nextCode = opt_thisOnly ? '' : this.blockToCode(nextBlock);
|
||||
return commentCode + code + nextCode;
|
||||
}
|
||||
|
||||
@@ -231,7 +231,6 @@ export class PythonGenerator extends CodeGenerator {
|
||||
* @protected
|
||||
*/
|
||||
quote_(string) {
|
||||
// Can't use goog.string.quote since % must also be escaped.
|
||||
string = string.replace(/\\/g, '\\\\').replace(/\n/g, '\\\n');
|
||||
|
||||
// Follow the CPython behaviour of repr() for a non-byte string.
|
||||
|
||||
Reference in New Issue
Block a user