From 1afff3c43998eab53c02b006ff33bb33cf260c91 Mon Sep 17 00:00:00 2001 From: Monica Kozbial Date: Thu, 16 Jan 2020 16:07:38 -0800 Subject: [PATCH] Use baseline for positioning rendered connection. (#3609) --- core/renderers/common/drawer.js | 3 +-- core/renderers/geras/drawer.js | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/core/renderers/common/drawer.js b/core/renderers/common/drawer.js index 268434b9b..b498bba1f 100644 --- a/core/renderers/common/drawer.js +++ b/core/renderers/common/drawer.js @@ -461,8 +461,7 @@ Blockly.blockRendering.Drawer.prototype.positionNextConnection_ = function() { var connInfo = bottomRow.connection; var x = connInfo.xPos; // Already contains info about startX var connX = (this.info_.RTL ? -x : x); - connInfo.connectionModel.setOffsetInBlock( - connX, (connInfo.centerline - connInfo.height / 2)); + connInfo.connectionModel.setOffsetInBlock(connX, bottomRow.baseline); } }; diff --git a/core/renderers/geras/drawer.js b/core/renderers/geras/drawer.js index 841965f94..d879dfdd4 100644 --- a/core/renderers/geras/drawer.js +++ b/core/renderers/geras/drawer.js @@ -211,7 +211,6 @@ Blockly.geras.Drawer.prototype.positionNextConnection_ = function() { var connX = (this.info_.RTL ? -x : x) + (this.constants_.DARK_PATH_OFFSET / 2); connInfo.connectionModel.setOffsetInBlock( - connX, (connInfo.centerline - connInfo.height / 2) + - this.constants_.DARK_PATH_OFFSET); + connX, bottomRow.baseline + this.constants_.DARK_PATH_OFFSET); } };