CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-07 17:10:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

chore: 'compareDocumentPosition' to 'contains' (#6982)

Browse Source 
The 'compareDocumentPosition' call was inherited from Closure Library, in order to work with IE 8 and earlier.  Use the more modern 'contains' call instead.

This change was originally added here:
https://github.com/google/blockly/pull/1991

Remove the DOCUMENT_POSITION_CONTAINED_BY constant which is not a NodeType and should never have been part of that enum.

This change was originally added here:
https://github.com/google/blockly/pull/2736
This commit is contained in:
Neil Fraser
2023-04-17 23:48:24 +02:00
committed by GitHub
parent 2bbb3aa1fc
commit 20f0c937cd
3 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/inject.ts
View File

@@ -47,8 +47,8 @@ export function inject(
containerElement = container;
}
// Verify that the container is in document.
if (!containerElement || !dom.containsNode(document, containerElement)) {
throw Error('Error: container is not in current document.');
if (!document.contains(containerElement)) {
throw Error('Error: container is not in current document');
}
const options = new Options(opt_options || {} as BlocklyOptions);
const subContainer = (document.createElement('div'));
@@ -56,7 +56,7 @@ export function inject(
subContainer.tabIndex = 0;
aria.setState(subContainer, aria.State.LABEL, Msg['WORKSPACE_ARIA_LABEL']);
containerElement.appendChild(subContainer);
containerElement!.appendChild(subContainer);
const svg = createDom(subContainer, options);
// Create surfaces for dragging things. These are optimizations