From 243116ca986710a3cb0f248362f26bf39d1734a7 Mon Sep 17 00:00:00 2001 From: Andrew n marshall Date: Thu, 23 Aug 2018 15:47:49 -0700 Subject: [PATCH] Adding warning old function name is detected. --- core/variables.js | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/core/variables.js b/core/variables.js index c5cefabfc..e4d346823 100644 --- a/core/variables.js +++ b/core/variables.js @@ -91,6 +91,12 @@ Blockly.Variables.allUsedVariables = function() { 'issue please file a bug on GitHub.'); }; +/** + * @private + * @type {Object} + */ +Blockly.Variables.ALL_DEVELOPER_VARS_WARNINGS_BY_BLOCK_TYPE_ = {}; + /** * Find all developer variables used by blocks in the workspace. * Developer variables are never shown to the user, but are declared as global @@ -106,7 +112,19 @@ Blockly.Variables.allDeveloperVariables = function(workspace) { var hash = {}; for (var i = 0; i < blocks.length; i++) { var block = blocks[i]; - var getDeveloperVariables = block.getDeveloperVariables || block.getDeveloperVars; + var getDeveloperVariables = block.getDeveloperVariables; + if (!getDeveloperVariables && block.getDeveloperVars) { + // getDeveloperVars was renamed getDeveloperVariables, already + // existing documentation. + getDeveloperVariables = block.getDeveloperVars; + if (!Blockly.Variables.ALL_DEVELOPER_VARS_WARNINGS_BY_BLOCK_TYPE_[ + block.type]) { + console.warn('Function getDeveloperVars() deprecated. Use ' + + 'getDeveloperVariables() (block type \'' + block.type + '\')'); + Blockly.Variables.ALL_DEVELOPER_VARS_WARNINGS_BY_BLOCK_TYPE_[ + block.type] = true; + } + } if (getDeveloperVariables) { var devVars = getDeveloperVariables(); for (var j = 0; j < devVars.length; j++) {