CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-04 15:40:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

Rename variableDB_ to nameDB_

Browse Source 
There is significant confusion in names and comments with regards to variables and procedures.  `Blockly.Generator.prototype.variableDB_` is a Blockly.Names database, not a variable map.  This rename introduces a getter and setter so deprecated references still work.  This commit also fixes some comments which are either outright wrong or misleading regarding variable and procedure names.
This commit is contained in:
Neil Fraser
2021-05-19 13:06:24 -07:00
committed by Neil Fraser
parent 5344ad6c21
commit 2f2252f588
45 changed files with 167 additions and 150 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
generators/php.js
View File

@@ -135,27 +135,27 @@ Blockly.PHP.init = function(workspace) {
// to actual function names (to avoid collisions with user functions).
Blockly.PHP.functionNames_ = Object.create(null);
if (!Blockly.PHP.variableDB_) {
Blockly.PHP.variableDB_ =
if (!Blockly.PHP.nameDB_) {
Blockly.PHP.nameDB_ =
new Blockly.Names(Blockly.PHP.RESERVED_WORDS_, '$');
} else {
Blockly.PHP.variableDB_.reset();
Blockly.PHP.nameDB_.reset();
}
Blockly.PHP.variableDB_.setVariableMap(workspace.getVariableMap());
Blockly.PHP.nameDB_.setVariableMap(workspace.getVariableMap());
var defvars = [];
// Add developer variables (not created or named by the user).
var devVarList = Blockly.Variables.allDeveloperVariables(workspace);
for (var i = 0; i < devVarList.length; i++) {
defvars.push(Blockly.PHP.variableDB_.getName(devVarList[i],
defvars.push(Blockly.PHP.nameDB_.getName(devVarList[i],
Blockly.Names.DEVELOPER_VARIABLE_TYPE) + ';');
}
// Add user variables, but only ones that are being used.
var variables = Blockly.Variables.allUsedVarModels(workspace);
for (var i = 0, variable; variable = variables[i]; i++) {
defvars.push(Blockly.PHP.variableDB_.getName(variable.getId(),
defvars.push(Blockly.PHP.nameDB_.getName(variable.getId(),
Blockly.VARIABLE_CATEGORY_NAME) + ';');
}
@@ -178,7 +178,7 @@ Blockly.PHP.finish = function(code) {
// Clean up temporary data.
delete Blockly.PHP.definitions_;
delete Blockly.PHP.functionNames_;
Blockly.PHP.variableDB_.reset();
Blockly.PHP.nameDB_.reset();
return definitions.join('\n\n') + '\n\n\n' + code;
};