CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-07 17:10:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: Don't warn if field is acually 0 width (#6558)

Browse Source 
One part of issue 6557.
This commit is contained in:
Neil Fraser
2022-10-18 23:01:41 +02:00
committed by GitHub
parent df660af66c
commit 321f619e28
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/field.ts
View File

@@ -797,10 +797,13 @@ export abstract class Field implements IASTNodeLocationSvg,
} else if (this.visible_ && this.size_.width === 0) { } else if (this.visible_ && this.size_.width === 0) {
// If the field is not visible the width will be 0 as well, one of the // If the field is not visible the width will be 0 as well, one of the
// problems with the old system. // problems with the old system.
console.warn(
'Deprecated use of setting size_.width to 0 to rerender a' +
' field. Set field.isDirty_ to true instead.');
this.render_(); this.render_();
// Don't issue a warning if the field is actually zero width.
if (this.size_.width !== 0) {
console.warn(
'Deprecated use of setting size_.width to 0 to rerender a' +
' field. Set field.isDirty_ to true instead.');
}
} }
return this.size_; return this.size_;
} }

3
core/utils/parsing.ts
View File

@@ -29,8 +29,7 @@ function tokenizeInterpolationInternal(
message: string, parseInterpolationTokens: boolean): (string|number)[] { message: string, parseInterpolationTokens: boolean): (string|number)[] {
const tokens = []; const tokens = [];
const chars = message.split(''); const chars = message.split('');
chars.push( // End marker. chars.push(''); // End marker.
'');
// Parse the message with a finite state machine. // Parse the message with a finite state machine.
// 0 - Base case. // 0 - Base case.
// 1 - % found. // 1 - % found.