From 7e03924d4ca3ef57a0d0401fd244fad0e023cc14 Mon Sep 17 00:00:00 2001 From: Beka Westberg Date: Tue, 31 Mar 2020 12:25:53 -0700 Subject: [PATCH] Remove mutator bump timeout. Anything that changes the shape of a block should be calling bumpNeighbors from inside BlockSvg. So this call is unnecessary. If this call is making something bump that normally wouldn't, that should be treated as a bug, and the root should be made to call bumpNieghbours. --- core/mutator.js | 7 ------- 1 file changed, 7 deletions(-) diff --git a/core/mutator.js b/core/mutator.js index 313e3f101..540178d05 100644 --- a/core/mutator.js +++ b/core/mutator.js @@ -386,13 +386,6 @@ Blockly.Mutator.prototype.workspaceChanged_ = function(e) { if (oldMutation != newMutation) { Blockly.Events.fire(new Blockly.Events.BlockChange( block, 'mutation', null, oldMutation, newMutation)); - // Ensure that any bump is part of this mutation's event group. - var group = Blockly.Events.getGroup(); - setTimeout(function() { - Blockly.Events.setGroup(group); - block.bumpNeighbours(); - Blockly.Events.setGroup(false); - }, Blockly.BUMP_DELAY); } // Don't update the bubble until the drag has ended, to avoid moving blocks