CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2025-12-16 06:10:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: Call onFinishEditing_ for fields on mobile. (#7483)

Browse Source 
On the desktop, widgetDispose_ will call onFinishEditing_ on close.

This was missing in the mobile counterpart, so any cleanups in onFinishEditing_ would not be called.

Also update the message string comment while we are touching this code.
This commit is contained in:
laurensvalk
2023-09-20 15:15:17 +02:00
committed by GitHub
parent ed043e7228
commit 3b234c7f87
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
core/field_input.ts
View File

@@ -342,6 +342,7 @@ export abstract class FieldInput<T extends InputTypes> extends Field<
if (text !== null) {
this.setValue(this.getValueFromEditorText_(text));
}
this.onFinishEditing_(this.value_);
},
);
}

2
msg/messages.js
View File

@@ -132,7 +132,7 @@ Blockly.Msg.REDO = 'Redo';
// Variable renaming.
/** @type {string} */
/// prompt - This message is only seen in the Opera browser. With most browsers, users can edit numeric values in blocks by just clicking and typing. Opera does not allows this, so we have to open a new window and prompt users with this message to chanage a value.
/// prompt - This message is seen on mobile devices and the Opera browser. With most browsers, users can edit numeric values in blocks by just clicking and typing. Opera does not allow this and mobile browsers may have issues with in-line textareas. So we prompt users with this message (usually a popup) to change a value.
Blockly.Msg.CHANGE_VALUE_TITLE = 'Change value:';
/** @type {string} */
/// dropdown choice - When the user clicks on a variable block, this is one of the dropdown menu choices. It is used to rename the current variable. See [https://github.com/google/blockly/wiki/Variables#dropdown-menu https://github.com/google/blockly/wiki/Variables#dropdown-menu].