diff --git a/tests/mocha/trashcan_test.js b/tests/mocha/trashcan_test.js index 7b763ef9f..51702faf6 100644 --- a/tests/mocha/trashcan_test.js +++ b/tests/mocha/trashcan_test.js @@ -31,7 +31,7 @@ suite("Trashcan", function() { } }; function sendDeleteEvent(xmlString) { - var xml = Blockly.Xml.textToDom(xmlString); + var xml = Blockly.Xml.textToDom('' + xmlString + ''); xml = xml.children[0]; var event = { type: Blockly.Events.BLOCK_DELETE, @@ -51,11 +51,7 @@ suite("Trashcan", function() { suite("Events", function() { test("Delete", function() { - sendDeleteEvent( - '' + - ' ' + - '' - ); + sendDeleteEvent(''); chai.assert.equal(this.trashcan.contents_.length, 1); }); test("Non-Delete", function() { @@ -80,270 +76,170 @@ suite("Trashcan", function() { chai.assert.equal(this.trashcan.contents_.length, 0); }); test("Shadow Delete", function() { - sendDeleteEvent( - '' + - ' ' + - '' - ); + sendDeleteEvent(''); chai.assert.equal(this.trashcan.contents_.length, 0); }); }); suite("Unique Contents", function() { test("Simple", function() { - sendDeleteEvent( - '' + - ' ' + - '' - ); - sendDeleteEvent( - '' + - ' ' + - '' - ); + sendDeleteEvent(''); + sendDeleteEvent(''); chai.assert.equal(this.trashcan.contents_.length, 1); }); test("Different Coords", function() { - sendDeleteEvent( - '' + - ' ' + - '' - ); - sendDeleteEvent( - '' + - ' ' + - '' - ); + sendDeleteEvent(''); + sendDeleteEvent(''); chai.assert.equal(this.trashcan.contents_.length, 1); }); test("Different IDs", function() { - sendDeleteEvent( - '' + - ' ' + - '' - ); - sendDeleteEvent( - '' + - ' ' + - '' - ); + sendDeleteEvent(''); + sendDeleteEvent(''); chai.assert.equal(this.trashcan.contents_.length, 1); }); test("No Disabled - Disabled True", function() { - sendDeleteEvent( - '' + - ' ' + - '' - ); - sendDeleteEvent( - '' + - ' ' + - '' - ); + sendDeleteEvent(''); + sendDeleteEvent(''); chai.assert.equal(this.trashcan.contents_.length, 2); }); test("No Editable - Editable False", function() { - sendDeleteEvent( - '' + - ' ' + - '' - ); - sendDeleteEvent( - '' + - ' ' + - '' - ); + sendDeleteEvent(''); + sendDeleteEvent(''); chai.assert.equal(this.trashcan.contents_.length, 2); }); test("No Movable - Movable False", function() { - sendDeleteEvent( - '' + - ' ' + - '' - ); - sendDeleteEvent( - '' + - ' ' + - '' - ); + sendDeleteEvent(''); + sendDeleteEvent(''); chai.assert.equal(this.trashcan.contents_.length, 2); }); test("Different Field Values", function() { sendDeleteEvent( - '' + - ' ' + - ' dummy_value1' + - ' ' + - '' + '' + + ' dummy_value1' + + '' ); sendDeleteEvent( - '' + - ' ' + - ' dummy_value2' + - ' ' + - '' + '' + + ' dummy_value2' + + '' ); chai.assert.equal(this.trashcan.contents_.length, 2); }); test("No Values - Values", function() { + sendDeleteEvent(''); sendDeleteEvent( - '' + - ' ' + - '' - ); - sendDeleteEvent( - '' + - ' ' + - ' ' + - ' ' + - ' ' + - ' ' + - '' + '' + + ' ' + + ' ' + + ' ' + + '' ); chai.assert.equal(this.trashcan.contents_.length, 2); }); test("Different Value Blocks", function() { sendDeleteEvent( - '' + - ' ' + - ' ' + - ' ' + - ' ' + - ' ' + - '' + '' + + ' ' + + ' ' + + ' ' + + '' ); sendDeleteEvent( - '' + - ' ' + - ' ' + - ' ' + - ' ' + - ' ' + - '' + '' + + ' ' + + ' ' + + ' ' + + '' ); chai.assert.equal(this.trashcan.contents_.length, 2); }); test("No Statements - Statements", function() { + sendDeleteEvent(''); sendDeleteEvent( - '' + - ' ' + - '' - ); - sendDeleteEvent( - '' + - ' ' + - ' ' + - ' ' + - ' ' + - ' ' + - '' + '' + + ' ' + + ' ' + + ' ' + + '' ); chai.assert.equal(this.trashcan.contents_.length, 2); }); test("Different Statement Blocks", function() { sendDeleteEvent( - '' + - ' ' + - ' ' + - ' ' + - ' ' + - ' ' + - '' + '' + + ' ' + + ' ' + + ' ' + + '' ); sendDeleteEvent( - '' + - ' ' + - ' ' + - ' ' + - ' ' + - ' ' + - '' + '' + + ' ' + + ' ' + + ' ' + + '' ); chai.assert.equal(this.trashcan.contents_.length, 2); }); test("No Next - Next", function() { + sendDeleteEvent(''); sendDeleteEvent( - '' + - ' ' + - '' - ); - sendDeleteEvent( - '' + - ' ' + - ' ' + - ' ' + - ' ' + - ' ' + - '' + '' + + ' ' + + ' ' + + ' ' + + '' ); chai.assert.equal(this.trashcan.contents_.length, 2); }); test("Different Next Blocks", function() { sendDeleteEvent( - '' + - ' ' + - ' ' + - ' ' + - ' ' + - ' ' + - '' + '' + + ' ' + + ' ' + + ' ' + + '' ); sendDeleteEvent( - '' + - ' ' + - ' ' + - ' ' + - ' ' + - ' ' + - '' + '' + + ' ' + + ' ' + + ' ' + + '' ); chai.assert.equal(this.trashcan.contents_.length, 2); }); test("No Comment - Comment", function() { + sendDeleteEvent(''); sendDeleteEvent( - '' + - ' ' + - '' - ); - sendDeleteEvent( - '' + - ' ' + - ' comment_text' + - ' ' + - '' + '' + + ' comment_text' + + '' ); chai.assert.equal(this.trashcan.contents_.length, 2); }); test("Different Comment Text", function() { sendDeleteEvent( - '' + - ' ' + - ' comment_text1' + - ' ' + - '' + '' + + ' comment_text1' + + '' ); sendDeleteEvent( - '' + - ' ' + - ' comment_text2' + - ' ' + - '' + '' + + ' comment_text2' + + '' ); chai.assert.equal(this.trashcan.contents_.length, 2); }); test("Different Comment Size", function() { sendDeleteEvent( - '' + - ' ' + - ' comment_text' + - ' ' + - '' + '' + + ' comment_text' + + '' ); sendDeleteEvent( - '' + - ' ' + - ' comment_text' + - ' ' + - '' + '' + + ' comment_text' + + '' ); // TODO: Is this how we want this to work? The difference is not // related to the content. @@ -351,52 +247,38 @@ suite("Trashcan", function() { }); test("Different Comment Pinned", function() { sendDeleteEvent( - '' + - ' ' + - ' comment_text' + - ' ' + - '' + '' + + ' comment_text' + + '' ); sendDeleteEvent( - '' + - ' ' + - ' comment_text' + - ' ' + - '' + '' + + ' comment_text' + + '' ); // TODO: Is this how we want this to work? The difference is not // related to the content. chai.assert.equal(this.trashcan.contents_.length, 2); }); test("No Mutator - Mutator", function() { + sendDeleteEvent(''); sendDeleteEvent( - '' + - ' ' + - '' - ); - sendDeleteEvent( - '' + - ' ' + - ' ' + - ' ' + - '' + '' + + ' ' + + '' ); chai.assert.equal(this.trashcan.contents_.length, 2); }); test("Different Mutator", function() { sendDeleteEvent( - '' + - ' ' + - ' ' + - ' ' + - '' + '' + + ' ' + + '' ); sendDeleteEvent( - '' + - ' ' + - ' ' + - ' ' + - '' + '' + + ' ' + + '' ); chai.assert.equal(this.trashcan.contents_.length, 2); }); @@ -414,16 +296,8 @@ suite("Trashcan", function() { }); test("Last In First Out", function() { workspace.options.maxTrashcanContents = 1; - sendDeleteEvent( - '' + - ' ' + - '' - ); - sendDeleteEvent( - '' + - ' ' + - '' - ); + sendDeleteEvent(''); + sendDeleteEvent(''); chai.assert.equal(this.trashcan.contents_.length, 1); chai.assert.equal( Blockly.Xml.textToDom(this.trashcan.contents_[0])