CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-08 09:30:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

chore: Reduce delta on ports to blockly-samples (#6886)

Browse Source 
* Reduce usage of obsolete .keyCode property.
* Rename private properties/methods which violate eslint rules.
* Use arrays of bound events rather than individual properties.
* Improve typing info.
* Also fix O(n^2) recursive performance issue in theme's getComponentStyle function.
* And replace String(...) with '${...}' (smaller, faster).
* .toString() is considered harmful.
This commit is contained in:
Neil Fraser
2023-03-15 21:28:57 +01:00
committed by GitHub
parent 66fd055a83
commit 42fde0f81b
56 changed files with 756 additions and 847 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/renderers/zelos/marker_svg.ts
View File

@@ -87,8 +87,8 @@ export class MarkerSvg extends BaseMarkerSvg {
* @param y The y position of the circle.
*/
private positionCircle_(x: number, y: number) {
this.markerCircle_?.setAttribute('cx', x.toString());
this.markerCircle_?.setAttribute('cy', y.toString());
this.markerCircle_?.setAttribute('cx', `${x}`);
this.markerCircle_?.setAttribute('cy', `${y}`);
this.currentMarkerSvg = this.markerCircle_;
}