mirror of
https://github.com/google/blockly.git
synced 2026-01-04 15:40:08 +01:00
chore: Reduce delta on ports to blockly-samples (#6886)
* Reduce usage of obsolete .keyCode property.
* Rename private properties/methods which violate eslint rules.
* Use arrays of bound events rather than individual properties.
* Improve typing info.
* Also fix O(n^2) recursive performance issue in theme's getComponentStyle function.
* And replace String(...) with '${...}' (smaller, faster).
* .toString() is considered harmful.
This commit is contained in:
@@ -59,7 +59,7 @@ function runTestTask(id, task) {
|
||||
successCount++;
|
||||
if (process.env.CI) console.log('::endgroup::');
|
||||
console.log(`${BOLD_GREEN}SUCCESS:${ANSI_RESET} ${id}`);
|
||||
results[id] = {success: true};
|
||||
results[id] = {success: true};
|
||||
resolve(result);
|
||||
})
|
||||
.catch((err) => {
|
||||
@@ -191,8 +191,8 @@ function compareSize(file, expected) {
|
||||
const message = `Failed: Previous size of ${name} is undefined.`;
|
||||
console.log(`${BOLD_RED}${message}${ANSI_RESET}`);
|
||||
return 1;
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
if (size > compare) {
|
||||
const message = `Failed: ` +
|
||||
`Size of ${name} has grown more than 10%. ${size} vs ${expected}`;
|
||||
|
||||
Reference in New Issue
Block a user