diff --git a/core/comment.js b/core/comment.js index 5127042fe..4c00a92e7 100644 --- a/core/comment.js +++ b/core/comment.js @@ -18,6 +18,7 @@ goog.require('Blockly.Events'); goog.require('Blockly.Events.BlockChange'); goog.require('Blockly.Events.Ui'); goog.require('Blockly.Icon'); +goog.require('Blockly.utils.deprecation'); goog.require('Blockly.utils.dom'); goog.require('Blockly.utils.object'); goog.require('Blockly.utils.userAgent'); @@ -364,6 +365,11 @@ Blockly.Comment.prototype.setBubbleSize = function(width, height) { * @deprecated August 2019 Use block.getCommentText() instead. */ Blockly.Comment.prototype.getText = function() { + Blockly.utils.deprecation.warn( + 'Comment.prototype.getText', + 'August 2019', + 'December 2020', + 'block.getCommentText'); return this.model_.text || ''; }; @@ -376,6 +382,11 @@ Blockly.Comment.prototype.getText = function() { * @deprecated August 2019 Use block.setCommentText() instead. */ Blockly.Comment.prototype.setText = function(text) { + Blockly.utils.deprecation.warn( + 'Comment.prototype.setText', + 'August 2019', + 'December 2020', + 'block.setCommentText'); if (this.model_.text == text) { return; } diff --git a/core/field.js b/core/field.js index a9d54ff2f..21f28eb76 100644 --- a/core/field.js +++ b/core/field.js @@ -18,6 +18,7 @@ goog.require('Blockly.Events'); goog.require('Blockly.Events.BlockChange'); goog.require('Blockly.Gesture'); goog.require('Blockly.utils'); +goog.require('Blockly.utils.deprecation'); goog.require('Blockly.utils.dom'); goog.require('Blockly.utils.Rect'); goog.require('Blockly.utils.Size'); @@ -537,6 +538,11 @@ Blockly.Field.prototype.getValidator = function() { * functions instead. */ Blockly.Field.prototype.classValidator = function(text) { + Blockly.utils.deprecation.warn( + 'Field.prototype.classValidator', + 'May 2019', + 'December 2020', + 'Blockly.Field.prototype.doClassValidation_'); return text; }; @@ -548,6 +554,10 @@ Blockly.Field.prototype.classValidator = function(text) { * @deprecated May 2019. setValue now contains all relevant logic. */ Blockly.Field.prototype.callValidator = function(text) { + Blockly.utils.deprecation.warn( + 'Field.prototype.callValidator', + 'May 2019', + 'December 2020'); var classResult = this.classValidator(text); if (classResult === null) { // Class validator rejects value. Game over. @@ -619,10 +629,12 @@ Blockly.Field.prototype.showEditor = function(opt_e) { * check the size of the field. */ Blockly.Field.prototype.updateWidth = function() { - console.warn('Deprecated call to updateWidth, call' + - ' Blockly.Field.updateSize_ to force an update to the size of the' + - ' field, or Blockly.utils.dom.getTextWidth() to check the size' + - ' of the field.'); + + Blockly.utils.deprecation.warn( + 'Field.prototype.updateWidth', + 'May 2019', + 'December 2020', + 'Blockly.Field.prototype.updateSize_ or Blockly.utils.dom.getTextWidth'); this.updateSize_(); }; @@ -809,6 +821,11 @@ Blockly.Field.prototype.getText = function() { * @deprecated 2019 setText should not be used directly. Use setValue instead. */ Blockly.Field.prototype.setText = function(_newText) { + Blockly.utils.deprecation.warn( + 'Field.prototype.setText', + 'May 2019', + 'December 2020', + 'Blockly.Field.prototype.setValue'); throw Error('setText method is deprecated'); }; diff --git a/core/rendered_connection.js b/core/rendered_connection.js index 5ceb347c4..cbf9994d4 100644 --- a/core/rendered_connection.js +++ b/core/rendered_connection.js @@ -16,6 +16,7 @@ goog.require('Blockly.Connection'); goog.require('Blockly.Events'); goog.require('Blockly.utils'); goog.require('Blockly.utils.Coordinate'); +goog.require('Blockly.utils.deprecation'); goog.require('Blockly.utils.dom'); goog.require('Blockly.utils.object'); @@ -424,6 +425,11 @@ Blockly.RenderedConnection.prototype.startTrackingAll = function() { */ Blockly.RenderedConnection.prototype.isConnectionAllowed = function(candidate, maxRadius) { + Blockly.utils.deprecation.warn( + 'RenderedConnection.prototype.isConnectionAllowed', + 'July 2020', + 'July 2021', + 'Blockly.Workspace.prototype.getConnectionChecker().canConnect'); if (this.distanceFrom(candidate) > maxRadius) { return false; }