CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-08 01:20:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use Blockly.utils.arrayRemove (#5420)

Browse Source 
Recently added code doesn't use existing utility function.
This commit is contained in:
Neil Fraser
2021-09-03 11:40:55 -07:00
committed by GitHub
parent e5830283ad
commit 49fcbc8411
5 changed files with 15 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/theme_manager.js
View File

@@ -15,6 +15,7 @@
goog.provide('Blockly.ThemeManager');
goog.require('Blockly.Theme');
goog.require('Blockly.utils');
goog.requireType('Blockly.Workspace');
goog.requireType('Blockly.WorkspaceSvg');
@@ -129,11 +130,9 @@ Blockly.ThemeManager.prototype.subscribeWorkspace = function(workspace) {
* @package
*/
Blockly.ThemeManager.prototype.unsubscribeWorkspace = function(workspace) {
var index = this.subscribedWorkspaces_.indexOf(workspace);
if (index < 0) {
if (!Blockly.utils.arrayRemove(this.subscribedWorkspaces_, workspace)) {
throw Error('Cannot unsubscribe a workspace that hasn\'t been subscribed.');
}
this.subscribedWorkspaces_.splice(index, 1);
};
/**