From 4a10ff833d70d687ac2db893d6ee828f2312cf6c Mon Sep 17 00:00:00 2001 From: Sam El-Husseini <16690124+samelhusseini@users.noreply.github.com> Date: Wed, 14 Aug 2019 14:14:49 -0700 Subject: [PATCH] Remove all calls to goog.events.KeyCodes (#2824) * Remove all calls to goog.events.keyCodes --- blockly_compressed.js | 26 +++++++++++++------------- blockly_uncompressed.js | 2 +- core/keyboard_nav/key_map.js | 22 ++++++++++++---------- tests/mocha/key_map_test.js | 9 +++++---- tests/mocha/navigation_test.js | 24 ++++++++++++------------ 5 files changed, 43 insertions(+), 40 deletions(-) diff --git a/blockly_compressed.js b/blockly_compressed.js index 8afdcde2d..4c57f2d4c 100644 --- a/blockly_compressed.js +++ b/blockly_compressed.js @@ -1374,7 +1374,7 @@ Blockly.utils.svgPaths.arc=function(a,b,c,d){return a+" "+c+" "+c+" "+b+d};Block Blockly.blockRendering.constants.TAB_HEIGHT=15;Blockly.blockRendering.constants.TAB_OFFSET_FROM_TOP=5;Blockly.blockRendering.constants.TAB_VERTICAL_OVERLAP=2.5;Blockly.blockRendering.constants.TAB_WIDTH=8;Blockly.blockRendering.constants.NOTCH_WIDTH=15;Blockly.blockRendering.constants.NOTCH_HEIGHT=4;Blockly.blockRendering.constants.MIN_BLOCK_WIDTH=12;Blockly.blockRendering.constants.EMPTY_BLOCK_SPACER_HEIGHT=16;Blockly.blockRendering.constants.CORNER_RADIUS=8; Blockly.blockRendering.constants.NOTCH_OFFSET_LEFT=Blockly.blockRendering.constants.NOTCH_WIDTH;Blockly.blockRendering.constants.NOTCH_OFFSET_ROUNDED_CORNER_PREV=Blockly.blockRendering.constants.NOTCH_OFFSET_LEFT-Blockly.blockRendering.constants.CORNER_RADIUS;Blockly.blockRendering.constants.STATEMENT_BOTTOM_SPACER=5;Blockly.blockRendering.constants.STATEMENT_INPUT_PADDING_LEFT=20;Blockly.blockRendering.constants.BETWEEN_STATEMENT_PADDING_Y=4;Blockly.blockRendering.constants.MAX_BOTTOM_WIDTH=66.5; Blockly.blockRendering.constants.START_HAT_HEIGHT=15;Blockly.blockRendering.constants.START_HAT_WIDTH=100;Blockly.blockRendering.constants.SPACER_DEFAULT_HEIGHT=15;Blockly.blockRendering.constants.MIN_BLOCK_HEIGHT=24;Blockly.blockRendering.constants.EMPTY_INLINE_INPUT_PADDING=14.5;Blockly.blockRendering.constants.EMPTY_INLINE_INPUT_HEIGHT=Blockly.blockRendering.constants.TAB_HEIGHT+11;Blockly.blockRendering.constants.EXTERNAL_VALUE_INPUT_PADDING=2; -Blockly.blockRendering.constants.EMPTY_STATEMENT_INPUT_HEIGHT=Blockly.blockRendering.constants.MIN_BLOCK_HEIGHT;Blockly.blockRendering.constants.EMPTY_STATEMENT_INPUT_WIDTH=32;Blockly.blockRendering.constants.POPULATED_STATEMENT_INPUT_WIDTH=25;Blockly.blockRendering.constants.START_POINT=Blockly.utils.svgPaths.moveBy(0,0);Blockly.blockRendering.constants.JAGGED_TEETH_HEIGHT=12;Blockly.blockRendering.constants.JAGGED_TEETH_WIDTH=6; +Blockly.blockRendering.constants.EMPTY_STATEMENT_INPUT_HEIGHT=Blockly.blockRendering.constants.MIN_BLOCK_HEIGHT;Blockly.blockRendering.constants.START_POINT=Blockly.utils.svgPaths.moveBy(0,0);Blockly.blockRendering.constants.JAGGED_TEETH_HEIGHT=12;Blockly.blockRendering.constants.JAGGED_TEETH_WIDTH=6; Blockly.blockRendering.constants.JAGGED_TEETH=function(){var a=Blockly.blockRendering.constants.JAGGED_TEETH_HEIGHT,b=Blockly.blockRendering.constants.JAGGED_TEETH_WIDTH,c=Blockly.utils.svgPaths.line([Blockly.utils.svgPaths.point(6,3),Blockly.utils.svgPaths.point(-12,6),Blockly.utils.svgPaths.point(6,3)]);return{height:a,width:b,path:c}}(); Blockly.blockRendering.constants.START_HAT=function(){var a=Blockly.blockRendering.constants.START_HAT_HEIGHT,b=Blockly.blockRendering.constants.START_HAT_WIDTH,c=Blockly.utils.svgPaths.curve("c",[Blockly.utils.svgPaths.point(30,-a),Blockly.utils.svgPaths.point(70,-a),Blockly.utils.svgPaths.point(b,0)]);return{height:a,width:b,path:c}}(); Blockly.blockRendering.constants.PUZZLE_TAB=function(){function a(a){a=a?-1:1;var d=-a,e=c/2,f=e+2.5,l=e+.5,n=Blockly.utils.svgPaths.point(-b,a*e);e=Blockly.utils.svgPaths.point(b,a*e);return Blockly.utils.svgPaths.curve("c",[Blockly.utils.svgPaths.point(0,a*f),Blockly.utils.svgPaths.point(-b,d*l),n])+Blockly.utils.svgPaths.curve("s",[Blockly.utils.svgPaths.point(b,2.5*d),e])}var b=Blockly.blockRendering.constants.TAB_WIDTH,c=Blockly.blockRendering.constants.TAB_HEIGHT,d=a(!0),e=a(!1);return{width:b, @@ -1391,8 +1391,8 @@ Blockly.blockRendering.JaggedEdge=function(){Blockly.blockRendering.JaggedEdge.s Blockly.blockRendering.Field=function(a,b){Blockly.blockRendering.Field.superClass_.constructor.call(this);this.field=a;this.isEditable=a.isCurrentlyEditable();this.flipRtl=a instanceof Blockly.FieldImage&&a.getFlipRtl();this.type="field";var c=this.field.getSize();this.height=c.height;this.width=c.width;this.parentInput=b};goog.inherits(Blockly.blockRendering.Field,Blockly.blockRendering.Measurable); Blockly.blockRendering.InlineInput=function(a){Blockly.blockRendering.InlineInput.superClass_.constructor.call(this,a);this.type="inline input";this.connectedBlock?(this.width=this.connectedBlockWidth+Blockly.blockRendering.constants.DARK_PATH_OFFSET,this.height=this.connectedBlockHeight+Blockly.blockRendering.constants.DARK_PATH_OFFSET):(this.height=Blockly.blockRendering.constants.EMPTY_INLINE_INPUT_HEIGHT,this.width=this.connectionShape.width+Blockly.blockRendering.constants.EMPTY_INLINE_INPUT_PADDING); this.connectionOffsetY=Blockly.blockRendering.constants.TAB_OFFSET_FROM_TOP;this.connectionHeight=this.connectionShape.height;this.connectionWidth=this.connectionShape.width};goog.inherits(Blockly.blockRendering.InlineInput,Blockly.blockRendering.Input); -Blockly.blockRendering.StatementInput=function(a){Blockly.blockRendering.StatementInput.superClass_.constructor.call(this,a);this.type="statement input";this.connectedBlock?(this.width=Blockly.blockRendering.constants.POPULATED_STATEMENT_INPUT_WIDTH,this.height=this.connectedBlockHeight+Blockly.blockRendering.constants.STATEMENT_BOTTOM_SPACER,this.connectedBlock.nextConnection&&(this.height-=this.notchShape.height)):(this.height=Blockly.blockRendering.constants.EMPTY_STATEMENT_INPUT_HEIGHT,this.width= -Blockly.blockRendering.constants.EMPTY_STATEMENT_INPUT_WIDTH)};goog.inherits(Blockly.blockRendering.StatementInput,Blockly.blockRendering.Input); +Blockly.blockRendering.StatementInput=function(a){Blockly.blockRendering.StatementInput.superClass_.constructor.call(this,a);this.type="statement input";this.connectedBlock?(this.height=this.connectedBlockHeight+Blockly.blockRendering.constants.STATEMENT_BOTTOM_SPACER,this.connectedBlock.nextConnection&&(this.height-=this.notchShape.height)):this.height=Blockly.blockRendering.constants.EMPTY_STATEMENT_INPUT_HEIGHT;this.width=Blockly.blockRendering.constants.NOTCH_OFFSET_LEFT+this.notchShape.width}; +goog.inherits(Blockly.blockRendering.StatementInput,Blockly.blockRendering.Input); Blockly.blockRendering.ExternalValueInput=function(a){Blockly.blockRendering.ExternalValueInput.superClass_.constructor.call(this,a);this.type="external value input";this.height=this.connectedBlock?this.connectedBlockHeight-2*Blockly.blockRendering.constants.TAB_OFFSET_FROM_TOP:this.connectionShape.height;this.width=this.connectionShape.width+Blockly.blockRendering.constants.EXTERNAL_VALUE_INPUT_PADDING;this.connectionOffsetY=Blockly.blockRendering.constants.TAB_OFFSET_FROM_TOP;this.connectionHeight= this.connectionShape.height;this.connectionWidth=this.connectionShape.width};goog.inherits(Blockly.blockRendering.ExternalValueInput,Blockly.blockRendering.Input);Blockly.blockRendering.OutputConnection=function(){Blockly.blockRendering.OutputConnection.superClass_.constructor.call(this);this.type="output connection";this.height=this.connectionShape.height;this.width=this.connectionShape.width;this.connectionOffsetY=Blockly.blockRendering.constants.TAB_OFFSET_FROM_TOP;this.startX=this.width}; goog.inherits(Blockly.blockRendering.OutputConnection,Blockly.blockRendering.Measurable);Blockly.blockRendering.PreviousConnection=function(){Blockly.blockRendering.PreviousConnection.superClass_.constructor.call(this);this.type="previous connection";this.height=this.notchShape.height;this.width=this.notchShape.width};goog.inherits(Blockly.blockRendering.PreviousConnection,Blockly.blockRendering.Measurable); @@ -1422,8 +1422,8 @@ Blockly.blockRendering.RenderInfo.prototype.getInRowSpacing_=function(a,b){if(!a b.isInput){if(a.isEditable){if(b.isInlineInput()||b.isExternalInput())return Blockly.blockRendering.constants.SMALL_PADDING}else{if(b.isInlineInput()||b.isExternalInput())return Blockly.blockRendering.constants.MEDIUM_LARGE_PADDING;if(b.isStatementInput())return Blockly.blockRendering.constants.LARGE_PADDING}return Blockly.blockRendering.constants.LARGE_PADDING-1}if(a.isIcon()&&!b.isInput)return Blockly.blockRendering.constants.LARGE_PADDING;if(a.isInlineInput()&&!b.isInput)return b.isEditable?Blockly.blockRendering.constants.MEDIUM_PADDING: Blockly.blockRendering.constants.LARGE_PADDING;if(a.isSquareCorner()){if(b.isHat())return Blockly.blockRendering.constants.NO_PADDING;if(b.isPreviousConnection())return Blockly.blockRendering.constants.NOTCH_OFFSET_LEFT;if(b.isNextConnection()){var c=(this.RTL?1:-1)*Blockly.blockRendering.constants.DARK_PATH_OFFSET/2;return Blockly.blockRendering.constants.NOTCH_OFFSET_LEFT+c}}if(a.isRoundedCorner()){if(b.isPreviousConnection())return Blockly.blockRendering.constants.NOTCH_OFFSET_ROUNDED_CORNER_PREV; if(b.isNextConnection())return c=(this.RTL?1:-1)*Blockly.blockRendering.constants.DARK_PATH_OFFSET/2,Blockly.blockRendering.constants.NOTCH_OFFSET_ROUNDED_CORNER_PREV+c}return!a.isInput&&!b.isInput&&a.isEditable==b.isEditable||b.isJaggedEdge()?Blockly.blockRendering.constants.LARGE_PADDING:Blockly.blockRendering.constants.MEDIUM_PADDING}; -Blockly.blockRendering.RenderInfo.prototype.computeBounds_=function(){for(var a=0,b=0,c=0,d=0;d} @@ -128,15 +130,15 @@ Blockly.user.keyMap.serializeKeyEvent = function(e) { */ Blockly.user.keyMap.createDefaultKeyMap = function() { var map = {}; - map[goog.events.KeyCodes.W] = Blockly.navigation.ACTION_PREVIOUS; - map[goog.events.KeyCodes.A] = Blockly.navigation.ACTION_OUT; - map[goog.events.KeyCodes.S] = Blockly.navigation.ACTION_NEXT; - map[goog.events.KeyCodes.D] = Blockly.navigation.ACTION_IN; - map[goog.events.KeyCodes.I] = Blockly.navigation.ACTION_INSERT; - map[goog.events.KeyCodes.ENTER] = Blockly.navigation.ACTION_MARK; - map[goog.events.KeyCodes.X] = Blockly.navigation.ACTION_DISCONNECT; - map[goog.events.KeyCodes.T] = Blockly.navigation.ACTION_TOOLBOX; - map[goog.events.KeyCodes.E] = Blockly.navigation.ACTION_EXIT; - map[goog.events.KeyCodes.ESC] = Blockly.navigation.ACTION_EXIT; + map[Blockly.utils.KeyCodes.W] = Blockly.navigation.ACTION_PREVIOUS; + map[Blockly.utils.KeyCodes.A] = Blockly.navigation.ACTION_OUT; + map[Blockly.utils.KeyCodes.S] = Blockly.navigation.ACTION_NEXT; + map[Blockly.utils.KeyCodes.D] = Blockly.navigation.ACTION_IN; + map[Blockly.utils.KeyCodes.I] = Blockly.navigation.ACTION_INSERT; + map[Blockly.utils.KeyCodes.ENTER] = Blockly.navigation.ACTION_MARK; + map[Blockly.utils.KeyCodes.X] = Blockly.navigation.ACTION_DISCONNECT; + map[Blockly.utils.KeyCodes.T] = Blockly.navigation.ACTION_TOOLBOX; + map[Blockly.utils.KeyCodes.E] = Blockly.navigation.ACTION_EXIT; + map[Blockly.utils.KeyCodes.ESC] = Blockly.navigation.ACTION_EXIT; return map; }; diff --git a/tests/mocha/key_map_test.js b/tests/mocha/key_map_test.js index 79010f97e..2b7d3a60b 100644 --- a/tests/mocha/key_map_test.js +++ b/tests/mocha/key_map_test.js @@ -12,15 +12,16 @@ suite('Key Map Tests', function() { }); test('Test giving an old action a new key', function() { - Blockly.user.keyMap.setActionForKey(goog.events.KeyCodes.F, Blockly.navigation.ACTION_PREVIOUS); - assertEquals(Blockly.user.keyMap.map_[goog.events.KeyCodes.W], undefined); - assertEquals(Blockly.user.keyMap.map_[goog.events.KeyCodes.F], + Blockly.user.keyMap.setActionForKey(Blockly.utils.KeyCodes.F, + Blockly.navigation.ACTION_PREVIOUS); + assertEquals(Blockly.user.keyMap.map_[Blockly.utils.KeyCodes.W], undefined); + assertEquals(Blockly.user.keyMap.map_[Blockly.utils.KeyCodes.F], Blockly.navigation.ACTION_PREVIOUS); }); test('Test get key by action defined', function() { var key = Blockly.user.keyMap.getKeyByAction(Blockly.navigation.ACTION_PREVIOUS); - assertEquals(key, goog.events.KeyCodes.W); + assertEquals(key, Blockly.utils.KeyCodes.W); }); test('Test get key by action undefined', function() { diff --git a/tests/mocha/navigation_test.js b/tests/mocha/navigation_test.js index 19bc0f68b..819de24e3 100644 --- a/tests/mocha/navigation_test.js +++ b/tests/mocha/navigation_test.js @@ -18,7 +18,7 @@ suite('Navigation', function() { test('Focuses workspace from flyout (e)', function() { Blockly.navigation.currentState_ = Blockly.navigation.STATE_FLYOUT; - this.mockEvent.keyCode = goog.events.KeyCodes.E; + this.mockEvent.keyCode = Blockly.utils.KeyCodes.E; chai.assert.isTrue(Blockly.navigation.onKeyPress(this.mockEvent)); chai.assert.equal(Blockly.navigation.currentState_, Blockly.navigation.STATE_WS); @@ -26,7 +26,7 @@ suite('Navigation', function() { test('Focuses workspace from flyout (escape)', function() { Blockly.navigation.currentState_ = Blockly.navigation.STATE_FLYOUT; - this.mockEvent.keyCode = goog.events.KeyCodes.ESC; + this.mockEvent.keyCode = Blockly.utils.KeyCodes.ESC; chai.assert.isTrue(Blockly.navigation.onKeyPress(this.mockEvent)); chai.assert.equal(Blockly.navigation.currentState_, Blockly.navigation.STATE_WS); @@ -71,7 +71,7 @@ suite('Navigation', function() { }); test('Next', function() { - this.mockEvent.keyCode = goog.events.KeyCodes.S; + this.mockEvent.keyCode = Blockly.utils.KeyCodes.S; chai.assert.isTrue(Blockly.navigation.onKeyPress(this.mockEvent)); chai.assert.equal(Blockly.navigation.currentState_, Blockly.navigation.STATE_TOOLBOX); @@ -82,7 +82,7 @@ suite('Navigation', function() { // Should be a no-op. test('Next at end', function() { Blockly.navigation.nextCategory(); - this.mockEvent.keyCode = goog.events.KeyCodes.S; + this.mockEvent.keyCode = Blockly.utils.KeyCodes.S; var startCategory = Blockly.navigation.currentCategory_; chai.assert.isTrue(Blockly.navigation.onKeyPress(this.mockEvent)); chai.assert.equal(Blockly.navigation.currentState_, @@ -94,7 +94,7 @@ suite('Navigation', function() { test('Previous', function() { // Go forward one so that we can go back one: Blockly.navigation.nextCategory(); - this.mockEvent.keyCode = goog.events.KeyCodes.W; + this.mockEvent.keyCode = Blockly.utils.KeyCodes.W; chai.assert.equal(Blockly.navigation.currentCategory_, this.secondCategory_); chai.assert.isTrue(Blockly.navigation.onKeyPress(this.mockEvent)); @@ -107,7 +107,7 @@ suite('Navigation', function() { // Should be a no-op. test('Previous at start', function() { var startCategory = Blockly.navigation.currentCategory_; - this.mockEvent.keyCode = goog.events.KeyCodes.W; + this.mockEvent.keyCode = Blockly.utils.KeyCodes.W; chai.assert.isTrue(Blockly.navigation.onKeyPress(this.mockEvent)); chai.assert.equal(Blockly.navigation.currentState_, Blockly.navigation.STATE_TOOLBOX); @@ -116,7 +116,7 @@ suite('Navigation', function() { }); test('Out', function() { - this.mockEvent.keyCode = goog.events.KeyCodes.A; + this.mockEvent.keyCode = Blockly.utils.KeyCodes.A; chai.assert.isTrue(Blockly.navigation.onKeyPress(this.mockEvent)); // TODO (fenichel/aschmiedt): Decide whether out should go to the // workspace. @@ -125,7 +125,7 @@ suite('Navigation', function() { }); test('Go to flyout', function() { - this.mockEvent.keyCode = goog.events.KeyCodes.D; + this.mockEvent.keyCode = Blockly.utils.KeyCodes.D; chai.assert.isTrue(Blockly.navigation.onKeyPress(this.mockEvent)); chai.assert.equal(Blockly.navigation.currentState_, Blockly.navigation.STATE_FLYOUT); @@ -135,14 +135,14 @@ suite('Navigation', function() { test('Focuses workspace from toolbox (e)', function() { Blockly.navigation.currentState_ = Blockly.navigation.STATE_TOOLBOX; - this.mockEvent.keyCode = goog.events.KeyCodes.E; + this.mockEvent.keyCode = Blockly.utils.KeyCodes.E; chai.assert.isTrue(Blockly.navigation.onKeyPress(this.mockEvent)); chai.assert.equal(Blockly.navigation.currentState_, Blockly.navigation.STATE_WS); }); test('Focuses workspace from toolbox (escape)', function() { Blockly.navigation.currentState_ = Blockly.navigation.STATE_TOOLBOX; - this.mockEvent.keyCode = goog.events.KeyCodes.E; + this.mockEvent.keyCode = Blockly.utils.KeyCodes.E; chai.assert.isTrue(Blockly.navigation.onKeyPress(this.mockEvent)); chai.assert.equal(Blockly.navigation.currentState_, Blockly.navigation.STATE_WS); @@ -192,11 +192,11 @@ suite('Navigation', function() { var numBlocks = this.workspace.getTopBlocks().length; - //Make sure the block was not connected to anything + // Make sure the block was not connected to anything chai.assert.isNull(this.basicBlock.previousConnection.targetConnection); chai.assert.isNull(this.basicBlock.nextConnection.targetConnection); - //Make sure that the block was added to the workspace + // Make sure that the block was added to the workspace chai.assert.equal(numBlocks, 3); chai.assert.equal(Blockly.navigation.currentState_, Blockly.navigation.STATE_WS);