From 5dbcaeb4e2cddb57e8fe62ce0a667b7e26ea5af1 Mon Sep 17 00:00:00 2001 From: Samriddhi Date: Mon, 9 Jan 2023 23:21:13 +0530 Subject: [PATCH] fix: change assertFieldValue in test helpers to use deepEqual (#6739) --- tests/mocha/field_angle_test.js | 4 ++-- tests/mocha/field_number_test.js | 6 +++--- tests/mocha/test_helpers/fields.js | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/mocha/field_angle_test.js b/tests/mocha/field_angle_test.js index d23acd80e..30af8340d 100644 --- a/tests/mocha/field_angle_test.js +++ b/tests/mocha/field_angle_test.js @@ -126,7 +126,7 @@ suite('Angle Fields', function() { function() { return null; }, - value: 2, expectedValue: 1}, + value: 2, expectedValue: '1'}, {title: 'Force Mult of 30 Validator', validator: function(newValue) { @@ -150,7 +150,7 @@ suite('Angle Fields', function() { }); test('When Not Editing', function() { this.field.setValue(suiteInfo.value); - assertFieldValue(this.field, suiteInfo.expectedValue); + assertFieldValue(this.field, +suiteInfo.expectedValue); }); }); }); diff --git a/tests/mocha/field_number_test.js b/tests/mocha/field_number_test.js index 23b112c81..93ece7a1c 100644 --- a/tests/mocha/field_number_test.js +++ b/tests/mocha/field_number_test.js @@ -202,11 +202,11 @@ suite('Number Fields', function() { function() { return null; }, - value: 2, expectedValue: 1}, + value: 2, expectedValue: '1'}, {title: 'Force End with 6 Validator', validator: function(newValue) { - return String(newValue).replace(/.$/, '6'); + return +String(newValue).replace(/.$/, '6'); }, value: 25, expectedValue: 26}, {title: 'Returns Undefined Validator', validator: function() {}, value: 2, @@ -226,7 +226,7 @@ suite('Number Fields', function() { }); test('When Not Editing', function() { this.field.setValue(suiteInfo.value); - assertFieldValue(this.field, suiteInfo.expectedValue); + assertFieldValue(this.field, +suiteInfo.expectedValue); }); }); }); diff --git a/tests/mocha/test_helpers/fields.js b/tests/mocha/test_helpers/fields.js index 8d796d4a6..f3f6b7315 100644 --- a/tests/mocha/test_helpers/fields.js +++ b/tests/mocha/test_helpers/fields.js @@ -73,8 +73,8 @@ export function assertFieldValue(field, expectedValue, expectedText = undefined) if (expectedText === undefined) { expectedText = String(expectedValue); } - chai.assert.equal(actualValue, expectedValue, 'Value'); - chai.assert.equal(actualText, expectedText, 'Text'); + chai.assert.deepEqual(actualValue, expectedValue); + chai.assert.deepEqual(actualText, expectedText); } /**