From 6050456bcf4146e750a40937c740cb28c3a74d23 Mon Sep 17 00:00:00 2001 From: Sam El-Husseini Date: Fri, 30 Aug 2019 15:44:44 -0700 Subject: [PATCH] Fix bug in base renderer, not respecting the bottom row's overhang Y property. (#2942) --- core/renderers/common/info.js | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/core/renderers/common/info.js b/core/renderers/common/info.js index 32d23eaa0..ea02fa8dc 100644 --- a/core/renderers/common/info.js +++ b/core/renderers/common/info.js @@ -467,14 +467,20 @@ Blockly.blockRendering.RenderInfo.prototype.getSpacerRowHeight_ = function( /** * Calculate the centerline of an element in a rendered row. * @param {Blockly.blockRendering.Row} row The row containing the element. - * @param {Blockly.blockRendering.Measurable} _elem The element to place. + * @param {Blockly.blockRendering.Measurable} elem The element to place. * @return {number} The desired centerline of the given element, as an offset * from the top left of the block. * @protected */ Blockly.blockRendering.RenderInfo.prototype.getElemCenterline_ = function(row, - _elem) { - return row.yPos + row.height / 2; + elem) { + var result = row.yPos; + if (elem.isNextConnection()) { + result += (row.height - row.overhangY + elem.height / 2); + } else { + result += (row.height / 2); + } + return result; }; /**