CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-07 17:10:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

chore: Remove underscores from private fields. (#8682)

Browse Source 
* chore: Remove underscores from private fields.

* refactor: Use public APIs in tests where possible.
This commit is contained in:
Aaron Dodson
2024-12-02 11:33:05 -08:00
committed by GitHub
parent 6f3f884345
commit 61bbd7dbf6
40 changed files with 378 additions and 401 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/flyout_base.ts
View File

@@ -207,7 +207,7 @@ export abstract class Flyout
/**
* Whether the flyout is visible.
*/
private isVisible_ = false;
private visible = false;
/**
* Whether the workspace containing this flyout is visible.
@@ -286,7 +286,7 @@ export abstract class Flyout
this.workspace_.internalIsFlyout = true;
// Keep the workspace visibility consistent with the flyout's visibility.
this.workspace_.setVisible(this.isVisible_);
this.workspace_.setVisible(this.visible);
/**
* The unique id for this component that is used to register with the
@@ -532,7 +532,7 @@ export abstract class Flyout
* @returns True if visible.
*/
isVisible(): boolean {
return this.isVisible_;
return this.visible;
}
/**
@@ -545,7 +545,7 @@ export abstract class Flyout
setVisible(visible: boolean) {
const visibilityChanged = visible !== this.isVisible();
this.isVisible_ = visible;
this.visible = visible;
if (visibilityChanged) {
if (!this.autoClose) {
// Auto-close flyouts are ignored as drag targets, so only non