From 69c5557e4f5633d3a3f00083082b2ab9fe43be61 Mon Sep 17 00:00:00 2001 From: Beka Westberg Date: Fri, 19 Apr 2024 18:15:56 +0000 Subject: [PATCH] chore: fix comments being resizable when readonly (#8043) --- core/comments/comment_view.ts | 5 +++++ tests/playground.html | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/core/comments/comment_view.ts b/core/comments/comment_view.ts index 4151c7cf9..4cb144b46 100644 --- a/core/comments/comment_view.ts +++ b/core/comments/comment_view.ts @@ -495,6 +495,8 @@ export class CommentView implements IRenderedElement { * comment. */ private onResizePointerDown(e: PointerEvent) { + if (!this.isEditable()) return; + this.bringToFront(); if (browserEvents.isRightButton(e)) { e.stopPropagation(); @@ -795,6 +797,9 @@ css.register(` height: 12px; cursor: se-resize; } +.blocklyReadonly.blocklyComment .blocklyResizeHandle { + cursor: inherit; +} .blocklyCommentTopbarBackground { fill: var(--commentBorderColour); diff --git a/tests/playground.html b/tests/playground.html index b06ce8efb..288c16958 100644 --- a/tests/playground.html +++ b/tests/playground.html @@ -251,7 +251,8 @@ if (sessionStorage) { sessionStorage.setItem('logFlyoutEvents', Number(state)); } - var flyoutWorkspace = workspace.getFlyout().getWorkspace(); + var flyoutWorkspace = workspace.getFlyout()?.getWorkspace(); + if (!flyoutWorkspace) return; if (state) { flyoutWorkspace.addChangeListener(logger); } else {