From 6bae750b10d0dff2f3a705143e1600e588618ed9 Mon Sep 17 00:00:00 2001 From: Rachel Fenichel Date: Fri, 27 Jan 2017 10:41:40 -0800 Subject: [PATCH] Don't try to get block position in a headless workspace --- core/events.js | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/core/events.js b/core/events.js index 12766f220..ddd5ca2ae 100644 --- a/core/events.js +++ b/core/events.js @@ -354,7 +354,12 @@ Blockly.Events.Create = function(block) { return; // Blank event to be populated by fromJson. } Blockly.Events.Create.superClass_.constructor.call(this, block); - this.xml = Blockly.Xml.blockToDomWithXY(block); + + if (block.workspace.rendered) { + this.xml = Blockly.Xml.blockToDomWithXY(block); + } else { + this.xml = Blockly.Xml.blockToDom(block); + } this.ids = Blockly.Events.getDescendantIds_(block); }; goog.inherits(Blockly.Events.Create, Blockly.Events.Abstract); @@ -423,7 +428,12 @@ Blockly.Events.Delete = function(block) { throw 'Connected blocks cannot be deleted.'; } Blockly.Events.Delete.superClass_.constructor.call(this, block); - this.oldXml = Blockly.Xml.blockToDomWithXY(block); + + if (block.workspace.rendered) { + this.oldXml = Blockly.Xml.blockToDomWithXY(block); + } else { + this.oldXml = Blockly.Xml.blockToDom(block); + } this.ids = Blockly.Events.getDescendantIds_(block); }; goog.inherits(Blockly.Events.Delete, Blockly.Events.Abstract);