From 6e300cc27c13582d827bb9c0c472ffb73f798918 Mon Sep 17 00:00:00 2001
From: Rachel Fenichel <fenichel@google.com>
Date: Fri, 9 Nov 2018 16:50:57 -0800
Subject: [PATCH] Add firefox to travis; quit early if files are not found in
 generator tests

---
 .travis.yml                     |  2 ++
 tests/scripts/run_generators.sh | 27 ++++++++++++++-------------
 2 files changed, 16 insertions(+), 13 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index de6192206..cf79ab11c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -12,6 +12,8 @@ matrix:
     - os: osx
       node_js: stable
       osx_image: xcode8.3
+      addons:
+        firefox: latest
 
 before_script:
   # Symlink closure library used by test/jsunit
diff --git a/tests/scripts/run_generators.sh b/tests/scripts/run_generators.sh
index a3a3e5b6d..9d556acad 100755
--- a/tests/scripts/run_generators.sh
+++ b/tests/scripts/run_generators.sh
@@ -14,21 +14,22 @@ FAILURE_COUNT=0
 check_result() {
   local suffix=$1 # One of: js, py, dart, lua, php
   local tmp_filename="${TMP_DIR}generated.$suffix"
-  if [ ! -f $tmp_filename ]; then
-    echo "File $tmp_filename not found!"
-    FAILURE_COUNT=$((FAILURE_COUNT+1))
-  fi
 
-  local golden_filename="${GOLDEN_DIR}generated.$suffix"
-  if [ ! -f $golden_filename ]; then
-    echo "File $golden_filename not found!"
-    FAILURE_COUNT=$((FAILURE_COUNT+1))
-  fi
-
-  if cmp --silent $tmp_filename $golden_filename; then
-    echo -e "$SUCCESS_PREFIX $suffix: $tmp_filename matches $golden_filename"
+  if [ -f $tmp_filename ]; then
+    local golden_filename="${GOLDEN_DIR}generated.$suffix"
+    if [ -f $golden_filename ]; then
+      if cmp --silent $tmp_filename $golden_filename; then
+        echo -e "$SUCCESS_PREFIX $suffix: $tmp_filename matches $golden_filename"
+      else
+        echo -e "$FAILURE_PREFIX $suffix: $tmp_filename does not match $golden_filename"
+        FAILURE_COUNT=$((FAILURE_COUNT+1))
+      fi
+    else
+      echo "File $golden_filename not found!"
+      FAILURE_COUNT=$((FAILURE_COUNT+1))
+    fi
   else
-    echo -e "$FAILURE_PREFIX $suffix: $tmp_filename does not match $golden_filename"
+    echo "File $tmp_filename not found!"
     FAILURE_COUNT=$((FAILURE_COUNT+1))
   fi
 }