From 701eecd5e1e794bc0e927c5a2b65519b11190e4c Mon Sep 17 00:00:00 2001 From: Sam El-Husseini Date: Thu, 10 Sep 2020 17:31:01 -0700 Subject: [PATCH] Revert google-closure-deps package to avoid regression, add test to catch this in the future (#4269) --- package-lock.json | 53 ++++++++++++++++++++++++------------------ package.json | 2 +- tests/run_all_tests.sh | 7 ++++-- 3 files changed, 36 insertions(+), 26 deletions(-) diff --git a/package-lock.json b/package-lock.json index 7ba70244f..21bffb206 100644 --- a/package-lock.json +++ b/package-lock.json @@ -3600,6 +3600,12 @@ "integrity": "sha512-DLlcY875mQB7PA9wtfbPBVL9chJj+si/cmxyp3euw7x09MiFYynR4tmQJ9KjWUffPbhvCRDEO/jKcVyNWQVS1Q==", "dev": true }, + "google-closure-compiler-js": { + "version": "20200719.0.0", + "resolved": "https://registry.npmjs.org/google-closure-compiler-js/-/google-closure-compiler-js-20200719.0.0.tgz", + "integrity": "sha512-cuowL5A4VOx9yxxMc3sSiqcj/d9aYjnHgFDvDB/dpMMOhlUMN1MDsVubuEc32tut7k/FTYFZY114CLH4r2q9/A==", + "dev": true + }, "google-closure-compiler-linux": { "version": "20200830.0.0", "resolved": "https://registry.npmjs.org/google-closure-compiler-linux/-/google-closure-compiler-linux-20200830.0.0.tgz", @@ -3622,56 +3628,57 @@ "optional": true }, "google-closure-deps": { - "version": "20200830.0.0", - "resolved": "https://registry.npmjs.org/google-closure-deps/-/google-closure-deps-20200830.0.0.tgz", - "integrity": "sha512-Oc5vMsR1RpYb8QZlWYdD46/V22E7ZGXaF/oPbpltKlKmNRpOO3jfIqfAotDKo9itA9SFCHnVfxHklmBSIOUyjw==", + "version": "20200719.0.0", + "resolved": "https://registry.npmjs.org/google-closure-deps/-/google-closure-deps-20200719.0.0.tgz", + "integrity": "sha512-BFWth9JZgaUwapaHMexxQbw4H9f/23rkD+GNKsyazVl8RSWma1s7i5fI/3AdEDcpgFMsyNbnEb3uOpaetSE6gA==", "dev": true, "requires": { "argparse": "^1.0.9", - "google-closure-compiler": "^20200830.0.0", + "google-closure-compiler": "^20200719.0.0", "yargs": "^12.0.2" }, "dependencies": { "google-closure-compiler": { - "version": "20200830.0.0", - "resolved": "https://registry.npmjs.org/google-closure-compiler/-/google-closure-compiler-20200830.0.0.tgz", - "integrity": "sha512-Pri8kyHGmd2xqLM38QBarx+fdkm2HuLniGz7GimbdjQ1KUuPNIz7IJOYc8NGGwYPGAB45vg4IZRk/LepAqnoxg==", + "version": "20200719.0.0", + "resolved": "https://registry.npmjs.org/google-closure-compiler/-/google-closure-compiler-20200719.0.0.tgz", + "integrity": "sha512-2fZl8M6U7KTXami1joNo9e5hW88iZX1MGBSHWlDaeBqSYkvLUH2Qn/VltAQuluSRBIjPXXhxZGKHyJamVoFFnA==", "dev": true, "requires": { "chalk": "2.x", - "google-closure-compiler-java": "^20200830.0.0", - "google-closure-compiler-linux": "^20200830.0.0", - "google-closure-compiler-osx": "^20200830.0.0", - "google-closure-compiler-windows": "^20200830.0.0", + "google-closure-compiler-java": "^20200719.0.0", + "google-closure-compiler-js": "^20200719.0.0", + "google-closure-compiler-linux": "^20200719.0.0", + "google-closure-compiler-osx": "^20200719.0.0", + "google-closure-compiler-windows": "^20200719.0.0", "minimist": "1.x", "vinyl": "2.x", "vinyl-sourcemaps-apply": "^0.2.0" } }, "google-closure-compiler-java": { - "version": "20200830.0.0", - "resolved": "https://registry.npmjs.org/google-closure-compiler-java/-/google-closure-compiler-java-20200830.0.0.tgz", - "integrity": "sha512-DLlcY875mQB7PA9wtfbPBVL9chJj+si/cmxyp3euw7x09MiFYynR4tmQJ9KjWUffPbhvCRDEO/jKcVyNWQVS1Q==", + "version": "20200719.0.0", + "resolved": "https://registry.npmjs.org/google-closure-compiler-java/-/google-closure-compiler-java-20200719.0.0.tgz", + "integrity": "sha512-/alYc8OC9zAETZ2m10OhtqI+PAs2b8y6cLn2VlN/53dHrCC6gKqj7Ajun/GAVAUOW4HMRMnpBYdCJgMLpAniSA==", "dev": true }, "google-closure-compiler-linux": { - "version": "20200830.0.0", - "resolved": "https://registry.npmjs.org/google-closure-compiler-linux/-/google-closure-compiler-linux-20200830.0.0.tgz", - "integrity": "sha512-QfxFA3+fOrNe0RH2lcXmkdiaM97KvZQOtO3trobNvfkMNr2h9OUtpXkqWExwolo/jsJWNumsdaRnEAwEthMUOw==", + "version": "20200719.0.0", + "resolved": "https://registry.npmjs.org/google-closure-compiler-linux/-/google-closure-compiler-linux-20200719.0.0.tgz", + "integrity": "sha512-hqPP8/7g7IMhcVle9xJ0aeiI4oRCucUGrWtQ12VwswKu2tyXTk2BDcXj5WqHae6TDPUONikQ8MCJSIENGLBC2Q==", "dev": true, "optional": true }, "google-closure-compiler-osx": { - "version": "20200830.0.0", - "resolved": "https://registry.npmjs.org/google-closure-compiler-osx/-/google-closure-compiler-osx-20200830.0.0.tgz", - "integrity": "sha512-qHKjRBJVq2+2mT25eoT6iOMVbUGT02sJUwkdLlsohWKV4sMEY8/nwnkZYsdm7KnPJnmQLlrfYJ1ZTh1VTlAJpQ==", + "version": "20200719.0.0", + "resolved": "https://registry.npmjs.org/google-closure-compiler-osx/-/google-closure-compiler-osx-20200719.0.0.tgz", + "integrity": "sha512-Y0RDdOAJ7CLya0pMjmLahiqh7b9aJGybKBTxPywK2CiJj1+z+EtvXN+QsaM0aSE8yvuvIbAWHOX4FjEXMRiTmw==", "dev": true, "optional": true }, "google-closure-compiler-windows": { - "version": "20200830.0.0", - "resolved": "https://registry.npmjs.org/google-closure-compiler-windows/-/google-closure-compiler-windows-20200830.0.0.tgz", - "integrity": "sha512-IpJAyxJo+GQ2DSVC4sslPydhIPyWRINkdNynIK/Bk+vbM/7i4LoEm/Y5rY/KJOLRCSds+s3Ov9LYdFkN8C//7g==", + "version": "20200719.0.0", + "resolved": "https://registry.npmjs.org/google-closure-compiler-windows/-/google-closure-compiler-windows-20200719.0.0.tgz", + "integrity": "sha512-U1onpG6RaTpRlR2nac+4GPU27LhJMr4kB4meNihwGvPRXcLh1qVcrKo+BjBuoX+Oq8KFwjc+mif3ldmv4AZzew==", "dev": true, "optional": true }, diff --git a/package.json b/package.json index 29a8d0f02..f34e63f8f 100644 --- a/package.json +++ b/package.json @@ -61,7 +61,7 @@ "eslint": "^7.6.0", "eslint-plugin-es5": "^1.5.0", "google-closure-compiler": "^20200830.0.0", - "google-closure-deps": "^20200830.0.0", + "google-closure-deps": "^20200719.0.0", "gulp": "^4.0.2", "gulp-concat": "^2.6.1", "gulp-insert": "^0.5.0", diff --git a/tests/run_all_tests.sh b/tests/run_all_tests.sh index 57ffa26cb..b289bdc97 100755 --- a/tests/run_all_tests.sh +++ b/tests/run_all_tests.sh @@ -61,8 +61,11 @@ run_test_command "node" "./node_modules/.bin/mocha tests/node --config tests/nod # Run generator tests inside a browser and check the results. run_test_command "generators" "tests/scripts/run_generators.sh" -# Run the closure compiler ensuring there are no errors. -run_test_command "compile" "npm run build:debug" +# Run the closure compiler. +run_test_command "compile" "npm run build" + +# Run the closure compiler ensuring there are no compiler warnings / errors. +run_test_command "compile:warnings" "npm run build:debug" # Generate TypeScript typings and ensure there are no errors. run_test_command "typings" "tests/scripts/compile_typings.sh"