CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-08 09:30:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: Properly size comments. (#8158)

Browse Source 
* Properly size comments.

Fixes multiple rendering and sizing issues across different browsers.

Tip: `text-overflow: hidden;` is not legal CSS and did nothing.

Resolves #8142
This commit is contained in:
Neil Fraser
2024-05-20 18:30:38 +02:00
committed by GitHub
parent 36b75696a2
commit 70ca676c24
3 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/bubbles/textinput_bubble.ts
View File

@@ -143,7 +143,7 @@ export class TextInputBubble extends Bubble {
/** Binds events to the text area element. */
private bindTextAreaEvents(textArea: HTMLTextAreaElement) {
// Don't zoom with mousewheel.
// Don't zoom with mousewheel; let it scroll instead.
browserEvents.conditionalBind(textArea, 'wheel', this, (e: Event) => {
e.stopPropagation();
});
@@ -198,8 +198,6 @@ export class TextInputBubble extends Bubble {
const heightMinusBorder = size.height - Bubble.DOUBLE_BORDER;
this.inputRoot.setAttribute('width', `${widthMinusBorder}`);
this.inputRoot.setAttribute('height', `${heightMinusBorder}`);
this.textArea.style.width = `${widthMinusBorder - 4}px`;
this.textArea.style.height = `${heightMinusBorder - 4}px`;
this.resizeGroup.setAttribute('y', `${heightMinusBorder}`);
if (this.workspace.RTL) {
@@ -310,6 +308,7 @@ Css.register(`
outline: 0;
padding: 3px;
resize: none;
text-overflow: hidden;
width: 100%;
height: 100%;
}
`);