mirror of
https://github.com/google/blockly.git
synced 2026-01-07 17:10:11 +01:00
Updating the templates to minimize checkboxes and use HTML comments. (#1394)
This commit is contained in:
committed by
GitHub
parent
ef14f0f306
commit
722ef5f3e1
50
.github/PULL_REQUEST_TEMPLATE.md
vendored
50
.github/PULL_REQUEST_TEMPLATE.md
vendored
@@ -1,7 +1,12 @@
|
||||
Thanks for submitting code to Blockly! Please fill out the following as part of your pull request so we can review your code more easily.
|
||||
<!--
|
||||
- Thanks for submitting code to Blockly! Please fill out the following as part of
|
||||
- your pull request so we can review your code more easily.
|
||||
-->
|
||||
|
||||
## The basics
|
||||
|
||||
<!-- TODO: Verify the following, checking each box with an 'x' between the brackets: [x] -->
|
||||
|
||||
- [ ] I branched from develop
|
||||
- [ ] My pull request is against develop
|
||||
- [ ] My code follows the [style guide](https://developers.google.com/blockly/guides/modify/web/style-guide)
|
||||
@@ -9,37 +14,40 @@ Thanks for submitting code to Blockly! Please fill out the following as part of
|
||||
## The details
|
||||
### Resolves
|
||||
|
||||
_What Github issue does this resolve (please include link)?_
|
||||
<!-- TODO: What Github issue does this resolve? Please include a link. -->
|
||||
|
||||
### Proposed Changes
|
||||
|
||||
_Describe what this Pull Request does. Include screenshots if applicable._
|
||||
<!-- TODO: Describe what this Pull Request does. Include screenshots if applicable. -->
|
||||
|
||||
### Reason for Changes
|
||||
|
||||
_Explain why these changes should be made. Include screenshots if applicable._
|
||||
<!--TODO: Explain why these changes should be made. Include screenshots if applicable. -->
|
||||
|
||||
### Test Coverage
|
||||
|
||||
_Please show how you have added tests to cover your changes, or tell us how you tested it and on which platforms._
|
||||
<!-- TODO: Please show how you have added tests to cover your changes,
|
||||
- or tell us how you tested it. For each systems you tested,
|
||||
- uncomment the systems in the list below.
|
||||
-->
|
||||
|
||||
Tested on:
|
||||
_Remove this hint: these checkboxes can be checked like this: [x]_
|
||||
- [ ] Desktop:
|
||||
- [ ] Chrome
|
||||
- [ ] Firefox
|
||||
- [ ] Safari
|
||||
- [ ] Opera
|
||||
- [ ] IE 10+
|
||||
- [ ] IE 11
|
||||
- [ ] EDGE
|
||||
<!-- * Desktop Chrome -->
|
||||
<!-- * Desktop Firefox -->
|
||||
<!-- * Desktop Safari -->
|
||||
<!-- * Desktop Opera -->
|
||||
<!-- * Windows Internet Explorer 10 -->
|
||||
<!-- * Windows Internet Explorer 11 -->
|
||||
<!-- * Windows Edge -->
|
||||
|
||||
<!--
|
||||
* Smartphone/Tablet/Chromebook (please complete the following information):
|
||||
* Device: [e.g. iPhone6]
|
||||
* OS: [e.g. iOS8.1]
|
||||
* Browser [e.g. stock browser, safari]
|
||||
* Version [e.g. 22]
|
||||
-->
|
||||
|
||||
- [ ] Smartphone/Tablet/Chromebook (please complete the following information):
|
||||
- Device: [e.g. iPhone6]
|
||||
- OS: [e.g. iOS8.1]
|
||||
- Browser [e.g. stock browser, safari]
|
||||
- Version [e.g. 22]
|
||||
|
||||
### Additional Information
|
||||
|
||||
_Anything else we should know?_
|
||||
<!-- Anything else we should know? -->
|
||||
|
||||
Reference in New Issue
Block a user