From 72b2af21006b840ec49c5fe2ce788a22ff29a04a Mon Sep 17 00:00:00 2001 From: Neil Fraser Date: Tue, 7 Feb 2023 23:37:25 +0100 Subject: [PATCH] fix: move deprecation warning to correct fromJson (#6831) Resolves #6830. https://groups.google.com/g/blockly/c/uy_8e7Q8XEw/m/8XveAYi3AQAJ --- core/events/events_abstract.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core/events/events_abstract.ts b/core/events/events_abstract.ts index 2da378866..a20d8c6b0 100644 --- a/core/events/events_abstract.ts +++ b/core/events/events_abstract.ts @@ -73,6 +73,9 @@ export abstract class Abstract { * @param json JSON representation. */ fromJson(json: AbstractEventJson) { + deprecation.warn( + 'Blockly.Events.Abstract.prototype.fromJson', 'version 9', 'version 10', + 'Blockly.Events.fromJson'); this.isBlank = false; this.group = json['group'] || ''; } @@ -88,9 +91,6 @@ export abstract class Abstract { */ static fromJson(json: AbstractEventJson, workspace: Workspace, event: any): Abstract { - deprecation.warn( - 'Blockly.Events.Abstract.prototype.fromJson', 'version 9', 'version 10', - 'Blockly.Events.fromJson'); event.isBlank = false; event.group = json['group'] || ''; event.workspaceId = workspace.id;