CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-07 09:00:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: type error in uneditable bubbles (#6092)

Browse Source
This commit is contained in:
Rachel Fenichel
2022-04-20 11:20:12 -07:00
committed by GitHub
parent f30a64c1bf
commit 7353c61b2b
2 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
core/browser_events.js
View File

@@ -219,10 +219,14 @@ const isTargetInput = function(e) {
if (e.target instanceof HTMLInputElement) {
const target = e.target;
return target.type === 'textarea' || target.type === 'text' ||
target.type === 'number' || target.type === 'email' ||
target.type === 'password' || target.type === 'search' ||
target.type === 'tel' || target.type === 'url';
return target.type === 'text' || target.type === 'number' ||
target.type === 'email' || target.type === 'password' ||
target.type === 'search' || target.type === 'tel' ||
target.type === 'url';
}
if (e.target instanceof HTMLTextAreaElement) {
return true;
}
}

4
core/bubble.js
View File

@@ -931,7 +931,9 @@ const Bubble = class {
// This cannot be done until the bubble is rendered on screen.
const maxWidth = paragraphElement.getBBox().width;
for (let i = 0, textElement;
(textElement = paragraphElement.childNodes[i]); i++) {
(textElement = /** @type {!SVGTSpanElement} */ (
paragraphElement.childNodes[i]));
i++) {
textElement.setAttribute('text-anchor', 'end');
textElement.setAttribute('x', maxWidth + Bubble.BORDER_WIDTH);
}