CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-07 09:00:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: undoing block delete over trashcan creates block in wrong place (#8126)

Browse Source
This commit is contained in:
Beka Westberg
2024-05-17 19:26:10 +00:00
committed by GitHub
parent 53cc12da77
commit 75d81620ab
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/dragging/dragger.ts
View File

@@ -13,6 +13,7 @@ import {WorkspaceSvg} from '../workspace_svg.js';
import {ComponentManager} from '../component_manager.js';
import {IDeleteArea} from '../interfaces/i_delete_area.js';
import * as registry from '../registry.js';
import * as eventUtils from '../events/utils.js';
export class Dragger implements IDragger {
protected startLoc: Coordinate;
@@ -94,6 +95,7 @@ export class Dragger implements IDragger {
/** Handles any drag cleanup. */
onDragEnd(e: PointerEvent) {
const origGroup = eventUtils.getGroup();
const dragTarget = this.workspace.getDragTarget(e);
if (dragTarget) {
this.dragTarget?.onDrop(this.draggable);
@@ -109,7 +111,12 @@ export class Dragger implements IDragger {
isDeletable(this.draggable) &&
this.wouldDeleteDraggable(e, this.draggable)
) {
// We want to make sure the delete gets grouped with any possible
// move event.
const newGroup = eventUtils.getGroup();
eventUtils.setGroup(origGroup);
this.draggable.dispose();
eventUtils.setGroup(newGroup);
}
}