CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-07 09:00:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: Fix bug that prevented keyboard navigation in flyouts. (#8687)

Browse Source 
* fix: Fix bug that prevented keyboard navigation in flyouts.

* refactor: Add an `isFocusable()` method to FlyoutItem.
This commit is contained in:
Aaron Dodson
2025-01-09 14:31:51 -08:00
committed by GitHub
parent 80a6d85c26
commit 75efba92e3
12 changed files with 203 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/interfaces/i_flyout.ts
View File

@@ -7,7 +7,7 @@
// Former goog.module ID: Blockly.IFlyout
import type {BlockSvg} from '../block_svg.js';
import {FlyoutItem} from '../flyout_base.js';
import type {FlyoutItem} from '../flyout_item.js';
import type {Coordinate} from '../utils/coordinate.js';
import type {Svg} from '../utils/svg.js';
import type {FlyoutDefinition} from '../utils/toolbox.js';

18
core/interfaces/i_flyout_inflater.ts
View File

@@ -1,5 +1,5 @@
import type {FlyoutItem} from '../flyout_item.js';
import type {WorkspaceSvg} from '../workspace_svg.js';
import type {IBoundedElement} from './i_bounded_element.js';
export interface IFlyoutInflater {
/**
@@ -16,7 +16,7 @@ export interface IFlyoutInflater {
* element, however.
* @returns The newly inflated flyout element.
*/
load(state: object, flyoutWorkspace: WorkspaceSvg): IBoundedElement;
load(state: object, flyoutWorkspace: WorkspaceSvg): FlyoutItem;
/**
* Returns the amount of spacing that should follow the element corresponding
@@ -26,7 +26,7 @@ export interface IFlyoutInflater {
* @param defaultGap The default gap for elements in this flyout.
* @returns The gap that should follow the given element.
*/
gapForElement(state: object, defaultGap: number): number;
gapForItem(state: object, defaultGap: number): number;
/**
* Disposes of the given element.
@@ -37,5 +37,15 @@ export interface IFlyoutInflater {
*
* @param element The flyout element to dispose of.
*/
disposeElement(element: IBoundedElement): void;
disposeItem(item: FlyoutItem): void;
/**
* Returns the type of items that this inflater is responsible for inflating.
* This should be the same as the name under which this inflater registers
* itself, as well as the value returned by `getType()` on the `FlyoutItem`
* objects returned by `load()`.
*
* @returns The type of items this inflater creates.
*/
getType(): string;
}