From 7e82d0d2019fca427d646abf3d280eba1030efe6 Mon Sep 17 00:00:00 2001 From: Sam El-Husseini Date: Fri, 25 Oct 2019 19:15:27 -0400 Subject: [PATCH] Remove @deprecated annotation on Blockly.bindEvent_ (#3333) --- core/blockly.js | 5 ++--- core/components/tree/treecontrol.js | 1 - core/flyout_base.js | 1 - core/inject.js | 1 - 4 files changed, 2 insertions(+), 6 deletions(-) diff --git a/core/blockly.js b/core/blockly.js index 11513dddc..e220741b8 100644 --- a/core/blockly.js +++ b/core/blockly.js @@ -522,9 +522,8 @@ Blockly.bindEventWithChecks_ = function(node, name, thisObject, func, /** * Bind an event to a function call. Handles multitouch events by using the * coordinates of the first changed touch, and doesn't do any safety checks for - * simultaneous event processing. - * @deprecated in favor of bindEventWithChecks_, but preserved for external - * users. + * simultaneous event processing. In most cases prefer is to use + * `Blockly.bindEventWithChecks_`. * @param {!EventTarget} node Node upon which to listen. * @param {string} name Event name to listen to (e.g. 'mousedown'). * @param {Object} thisObject The value of 'this' in the function. diff --git a/core/components/tree/treecontrol.js b/core/components/tree/treecontrol.js index 7e9a58659..a498b6938 100644 --- a/core/components/tree/treecontrol.js +++ b/core/components/tree/treecontrol.js @@ -263,7 +263,6 @@ Blockly.tree.TreeControl.prototype.exitDocument = function() { /** * Adds the event listeners to the tree. * @private - * @suppress {deprecated} Suppress deprecated bindEvent_ call. */ Blockly.tree.TreeControl.prototype.attachEvents_ = function() { var el = this.getElement(); diff --git a/core/flyout_base.js b/core/flyout_base.js index 61202150e..90ad2357d 100644 --- a/core/flyout_base.js +++ b/core/flyout_base.js @@ -579,7 +579,6 @@ Blockly.Flyout.prototype.clearOldBlocks_ = function() { * @param {!SVGElement} rect The invisible rectangle under the block that acts * as a mat for that block. * @protected - * @suppress {deprecated} Suppress deprecated bindEvent_ call. */ Blockly.Flyout.prototype.addBlockListeners_ = function(root, block, rect) { this.listeners_.push(Blockly.bindEventWithChecks_(root, 'mousedown', null, diff --git a/core/inject.js b/core/inject.js index 456a35af5..45c638627 100644 --- a/core/inject.js +++ b/core/inject.js @@ -456,7 +456,6 @@ Blockly.init_ = function(mainWorkspace) { * Also, 'keydown' has to be on the whole document since the browser doesn't * understand a concept of focus on the SVG image. * @private - * @suppress {deprecated} Suppress deprecated bindEvent_ call. */ Blockly.inject.bindDocumentEvents_ = function() { if (!Blockly.documentEventsBound_) {