CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-06 08:30:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix order errors in text generators (#4329)

Browse Source 
* Fix dart text generator logic

* Fix Javascript text generator logic.

* Fix Lua text generator logic

* Fix php text generator logic

* Fix python text generator logic

* Fix error in substring logic

* Fix unit test block generators

* Update from ORDER_COMMA to ORDER_NONE

* Update golden files
This commit is contained in:
Monica Kozbial
2020-09-30 14:08:45 -07:00
committed by GitHub
parent 64fe425944
commit 81d355f5fa
17 changed files with 139 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
generators/php.js
View File

@@ -190,7 +190,7 @@ Blockly.PHP.scrubNakedValue = function(line) {
* quotes.
* @param {string} string Text to encode.
* @return {string} PHP string.
* @private
* @protected
*/
Blockly.PHP.quote_ = function(string) {
string = string.replace(/\\/g, '\\\\')
@@ -204,7 +204,7 @@ Blockly.PHP.quote_ = function(string) {
* quotes.
* @param {string} string Text to encode.
* @return {string} PHP string.
* @private
* @protected
*/
Blockly.PHP.multiline_quote_ = function (string) {
var lines = string.split(/\n/g).map(Blockly.PHP.quote_);
@@ -222,7 +222,7 @@ Blockly.PHP.multiline_quote_ = function (string) {
* @param {string} code The PHP code created for this block.
* @param {boolean=} opt_thisOnly True to generate code for only this statement.
* @return {string} PHP code with comments and subsequent blocks added.
* @private
* @protected
*/
Blockly.PHP.scrub_ = function(block, code, opt_thisOnly) {
var commentCode = '';