CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-03-10 15:20:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix order errors in text generators (#4329)

Browse Source 
* Fix dart text generator logic

* Fix Javascript text generator logic.

* Fix Lua text generator logic

* Fix php text generator logic

* Fix python text generator logic

* Fix error in substring logic

* Fix unit test block generators

* Update from ORDER_COMMA to ORDER_NONE

* Update golden files
This commit is contained in:
Monica Kozbial
2020-09-30 14:08:45 -07:00
committed by GitHub
parent 64fe425944
commit 81d355f5fa
17 changed files with 139 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/generators/unittest_javascript.js
View File

@@ -106,9 +106,9 @@ Blockly.JavaScript['unittest_assertequals'] = function(block) {
var message = Blockly.JavaScript.valueToCode(block, 'MESSAGE',
Blockly.JavaScript.ORDER_NONE) || '';
var actual = Blockly.JavaScript.valueToCode(block, 'ACTUAL',
Blockly.JavaScript.ORDER_COMMA) || 'null';
Blockly.JavaScript.ORDER_NONE) || 'null';
var expected = Blockly.JavaScript.valueToCode(block, 'EXPECTED',
Blockly.JavaScript.ORDER_COMMA) || 'null';
Blockly.JavaScript.ORDER_NONE) || 'null';
return Blockly.JavaScript['unittest_main'].defineAssert_() +
'(' + actual + ', ' + expected + ', ' + message + ');\n';
};
@@ -118,7 +118,7 @@ Blockly.JavaScript['unittest_assertvalue'] = function(block) {
var message = Blockly.JavaScript.valueToCode(block, 'MESSAGE',
Blockly.JavaScript.ORDER_NONE) || '';
var actual = Blockly.JavaScript.valueToCode(block, 'ACTUAL',
Blockly.JavaScript.ORDER_COMMA) || 'null';
Blockly.JavaScript.ORDER_NONE) || 'null';
var expected = block.getFieldValue('EXPECTED');
if (expected == 'TRUE') {
expected = 'true';