From 85b50fcb73f82cd4b159087846185525fcaccd84 Mon Sep 17 00:00:00 2001 From: Christopher Allen Date: Sat, 10 Jul 2021 13:13:53 +0100 Subject: [PATCH] Use fs.mkdirSync instead of execSync('mkdir -p ...') Also consistently use {recursive: true} in case directory is nested in an also-not-yet-existent directory. --- scripts/gulpfiles/appengine_tasks.js | 4 ++-- scripts/gulpfiles/build_tasks.js | 2 +- scripts/gulpfiles/package_tasks.js | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/gulpfiles/appengine_tasks.js b/scripts/gulpfiles/appengine_tasks.js index 5e3f7d681..04ef14402 100644 --- a/scripts/gulpfiles/appengine_tasks.js +++ b/scripts/gulpfiles/appengine_tasks.js @@ -28,8 +28,8 @@ function prepareDeployDir(done) { if (fs.existsSync(demoTmpDir)) { rimraf.sync(demoTmpDir); } - fs.mkdirSync(demoStaticTmpDir, { recursive: true }); - done() + fs.mkdir(demoStaticTmpDir, {recursive: true}); + done(); } /** diff --git a/scripts/gulpfiles/build_tasks.js b/scripts/gulpfiles/build_tasks.js index b27d21a5b..108b186a0 100644 --- a/scripts/gulpfiles/build_tasks.js +++ b/scripts/gulpfiles/build_tasks.js @@ -448,7 +448,7 @@ function buildLangfiles(done) { // Create output directory. // TODO(#5000): does mkidr -p work on Windows? const outputDir = path.join(BUILD_DIR, 'msg', 'js'); - execSync(`mkdir -p ${outputDir}`, {stdio: 'inherit'}); + fs.mkdirSync(outputDir, {recursive: true}); // Run create_messages.py. let json_files = fs.readdirSync(path.join('msg', 'json')); diff --git a/scripts/gulpfiles/package_tasks.js b/scripts/gulpfiles/package_tasks.js index 66bfadd06..fefb2d9f8 100644 --- a/scripts/gulpfiles/package_tasks.js +++ b/scripts/gulpfiles/package_tasks.js @@ -374,7 +374,7 @@ function packageJSON(cb) { const json = Object.assign({}, packageJson); delete json['scripts']; if (!fs.existsSync(RELEASE_DIR)) { - fs.mkdirSync(RELEASE_DIR); + fs.mkdirSync(RELEASE_DIR, {recursive: true}); } fs.writeFileSync(`${RELEASE_DIR}/package.json`, JSON.stringify(json, null, 2));