From 8abba6ae10c135d6b520829e6d7f9cd1339df736 Mon Sep 17 00:00:00 2001 From: RoboErikG Date: Fri, 12 Jul 2019 13:29:46 -0700 Subject: [PATCH] Remove edit handler that is just eating events (#2634) This handler should be unnecessary on most versions of Android, and it's currently just swallowing events that would be handled by default. Removing it to let the system take the default action. --- .../blockly/android/webview/JsDialogHelper.java | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/demos/mobile/android/app/src/main/java/com/google/blockly/android/webview/JsDialogHelper.java b/demos/mobile/android/app/src/main/java/com/google/blockly/android/webview/JsDialogHelper.java index c03f62146..0849d0a27 100644 --- a/demos/mobile/android/app/src/main/java/com/google/blockly/android/webview/JsDialogHelper.java +++ b/demos/mobile/android/app/src/main/java/com/google/blockly/android/webview/JsDialogHelper.java @@ -115,19 +115,6 @@ public class JsDialogHelper { builder.setNegativeButton(android.R.string.cancel, new CancelListener()); } final AlertDialog dialog = builder.show(); - - if (edit != null) { // Is it a prompt dialog? - edit.setOnEditorActionListener(new TextView.OnEditorActionListener() { - @Override - public boolean onEditorAction(TextView v, int actionId, KeyEvent event) { - if (actionId == EditorInfo.IME_ACTION_DONE) { - // TODO: Accept input, close keyboard, close dialog - return true; - } - return false; - } - }); - } } private class CancelListener implements DialogInterface.OnCancelListener,