From 91b570ace55d610a63d7e5a3f30b6fc0dfc56630 Mon Sep 17 00:00:00 2001
From: Beka Westberg <bwestberg@google.com>
Date: Wed, 11 May 2022 19:07:01 -0700
Subject: [PATCH] fix: add timeouts to delay expensive mutation operations
 (#6149)

* fix: add timeouts to delay expensive operations

* fix: format
---
 core/mutator.js | 31 +++++++++++++++++++++++++------
 1 file changed, 25 insertions(+), 6 deletions(-)

diff --git a/core/mutator.js b/core/mutator.js
index db2f1867f..b9ce47f2b 100644
--- a/core/mutator.js
+++ b/core/mutator.js
@@ -101,6 +101,13 @@ class Mutator extends Icon {
      * @private
      */
     this.sourceListener_ = null;
+
+    /**
+     * The PID associated with the updateWorkpace_ timeout, or 0 if no timeout
+     * is currently running.
+     * @type {number}
+     */
+    this.updateWorkspacePid_ = 0;
   }
 
   /**
@@ -402,14 +409,26 @@ class Mutator extends Icon {
    * @private
    */
   workspaceChanged_(e) {
-    if (!(e.isUiEvent ||
-          (e.type === eventUtils.CHANGE &&
-           /** @type {!BlockChange} */ (e).element === 'disabled') ||
-          e.type === eventUtils.CREATE)) {
-      this.updateWorkspace_();
+    if (!this.shouldIgnoreMutatorEvent_(e) && !this.updateWorkspacePid_) {
+      this.updateWorkspacePid_ = setTimeout(() => {
+        this.updateWorkspacePid_ = 0;
+        this.updateWorkspace_();
+      }, 0);
     }
   }
 
+  /**
+   * Returns whether the given event in the mutator workspace should be ignored
+   * when deciding whether to update the workspace and compose the block or not.
+   * @param {!Abstract} e The event.
+   * @return {boolean} Whether to ignore the event or not.
+   */
+  shouldIgnoreMutatorEvent_(e) {
+    return e.isUiEvent || e.type === eventUtils.CREATE ||
+        e.type === eventUtils.CHANGE &&
+        /** @type {!BlockChange} */ (e).element === 'disabled';
+  }
+
   /**
    * Updates the source block when the mutator's blocks are changed.
    * Bump down any block that's too high.
@@ -485,7 +504,7 @@ class Mutator extends Icon {
       // Don't update the bubble until the drag has ended, to avoid moving
       // blocks under the cursor.
       if (!this.workspace_.isDragging()) {
-        this.resizeBubble_();
+        setTimeout(() => this.resizeBubble_(), 0);
       }
       eventUtils.setGroup(existingGroup);
     }