CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-07 17:10:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Treat compiler warnings as errors and run on travis (#3378)

Browse Source 
* Enable compiler warnings as errors and run on travis
This commit is contained in:
Sam El-Husseini
2019-10-31 15:49:28 -07:00
committed by GitHub
parent 123f436e04
commit 93755fef53
7 changed files with 83 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/insertion_marker_manager.js
View File

@@ -570,8 +570,8 @@ Blockly.InsertionMarkerManager.prototype.highlightBlock_ = function() {
closest.targetBlock().highlightForReplacement(true);
} else if (local.type == Blockly.OUTPUT_VALUE) {
this.highlightedBlock_ = closest.getSourceBlock();
// TODO: remove?
closest.getSourceBlock().highlightShapeForInput(closest, true);
// TODO: Bring this back for zelos rendering.
// closest.getSourceBlock().highlightShapeForInput(closest, true);
}
this.highlightingBlock_ = true;
};
@@ -585,7 +585,8 @@ Blockly.InsertionMarkerManager.prototype.unhighlightBlock_ = function() {
// If there's no block in place, but we're still connecting to a value input,
// then we must have been highlighting an input shape.
if (closest.type == Blockly.INPUT_VALUE && !closest.isConnected()) {
this.highlightedBlock_.highlightShapeForInput(closest, false);
// TODO: Bring this back for zelos rendering.
// this.highlightedBlock_.highlightShapeForInput(closest, false);
} else {
this.highlightedBlock_.highlightForReplacement(false);
}