refactor: Mark optional parameters as optional. (#6380)

* refactor: Mark optional params as optional.

* refactor: Slightly narrow the typing of rendererOverrides.
This commit is contained in:
Aaron Dodson
2022-08-24 13:19:37 -07:00
committed by GitHub
parent 1f6481e527
commit 980fe138e7
5 changed files with 9 additions and 7 deletions

View File

@@ -38,7 +38,7 @@ export class BubbleOpen extends UiBase {
* 'warning'. Undefined for a blank event.
*/
constructor(
opt_block: BlockSvg, opt_isOpen?: boolean, opt_bubbleType?: string) {
opt_block?: BlockSvg, opt_isOpen?: boolean, opt_bubbleType?: string) {
const workspaceId = opt_block ? opt_block.workspace.id : undefined;
super(workspaceId);
this.blockId = opt_block ? opt_block.id : null;

View File

@@ -56,7 +56,7 @@ export class FlyoutMetricsManager extends MetricsManager {
return blockBoundingBox;
}
override getContentMetrics(opt_getWorkspaceCoordinates: boolean) {
override getContentMetrics(opt_getWorkspaceCoordinates?: boolean) {
// The bounding box is in workspace coordinates.
const blockBoundingBox = this.getBoundingBox_();
const scale = opt_getWorkspaceCoordinates ? 1 : this.workspace_.scale;
@@ -70,8 +70,8 @@ export class FlyoutMetricsManager extends MetricsManager {
}
override getScrollMetrics(
opt_getWorkspaceCoordinates: boolean, opt_viewMetrics: ContainerRegion,
opt_contentMetrics: ContainerRegion) {
opt_getWorkspaceCoordinates?: boolean, opt_viewMetrics?: ContainerRegion,
opt_contentMetrics?: ContainerRegion) {
// AnyDuringMigration because: Expected 1 arguments, but got 0.
const contentMetrics =
opt_contentMetrics || (this.getContentMetrics as AnyDuringMigration)();

View File

@@ -296,7 +296,7 @@ export function getObject<T>(
* @alias Blockly.registry.getAllItems
*/
export function getAllItems<T>(
type: string|Type<T>, opt_cased: boolean, opt_throwIfMissing?: boolean):
type: string|Type<T>, opt_cased?: boolean, opt_throwIfMissing?: boolean):
{[key: string]: T|null|(new (...p1: AnyDuringMigration[]) => T)}|null {
type = String(type).toLowerCase();
const typeRegistry = typeMap[type];

View File

@@ -77,7 +77,8 @@ export class Renderer implements IRegistrable {
* @param opt_rendererOverrides Rendering constant overrides.
* @internal
*/
init(theme: Theme, opt_rendererOverrides?: object) {
init(
theme: Theme, opt_rendererOverrides?: {[rendererConstant: string]: any}) {
this.constants_ = this.makeConstants_();
if (opt_rendererOverrides) {
this.overrides = opt_rendererOverrides;

View File

@@ -51,7 +51,8 @@ export class Renderer extends BaseRenderer {
*
* @internal
*/
override init(theme: Theme, opt_rendererOverrides: AnyDuringMigration) {
override init(
theme: Theme, opt_rendererOverrides?: {[rendererConstant: string]: any}) {
super.init(theme, opt_rendererOverrides);
this.highlightConstants_ = this.makeHighlightConstants_();
this.highlightConstants_.init();