Private/protected visibility cleanup (#3263)

* Fix a number of private visibility issues
This commit is contained in:
Sam El-Husseini
2019-10-16 11:48:09 -05:00
committed by GitHub
parent 01b6992efd
commit 986e965be8
22 changed files with 38 additions and 19 deletions

View File

@@ -71,7 +71,7 @@ BlockFactory.updateBlocksFlag = false;
// TODO: Replace global state with parameter passed to functions.
BlockFactory.updateBlocksFlagDelayed = false;
/*
/**
* The starting XML for the Block Factory main workspace. Contains the
* unmovable, undeletable factory_base block.
*/

View File

@@ -988,7 +988,7 @@ FactoryUtils.cleanXml = function(xml) {
return newXml;
};
/*
/**
* Checks if a block has a variable field. Blocks with variable fields cannot
* be shadow blocks.
* @param {Blockly.Block} block The block to check if a variable field exists.

View File

@@ -917,7 +917,7 @@ WorkspaceFactoryController.prototype.clearAll = function() {
this.updatePreview();
};
/*
/**
* Makes the currently selected block a user-generated shadow block. These
* blocks are not made into real shadow blocks, but recorded in the model
* and visually marked as shadow blocks, allowing the user to move and edit
@@ -1262,7 +1262,7 @@ WorkspaceFactoryController.prototype.importBlocks = function(file, format) {
reader.readAsText(file);
};
/*
/**
* Updates the block library category in the toolbox workspace toolbox.
* @param {!Element} categoryXml XML for the block library category.
* @param {!Array.<string>} libBlockTypes Array of block types from the block
@@ -1323,7 +1323,7 @@ WorkspaceFactoryController.prototype.warnForUndefinedBlocks_ = function() {
}
};
/*
/**
* Determines if a standard variable category is in the custom toolbox.
* @return {boolean} True if a variables category is in use, false otherwise.
*/

View File

@@ -390,7 +390,7 @@ WorkspaceFactoryModel.prototype.setOptions = function(options) {
this.options = options;
};
/*
/**
* Returns an array of all the block types currently being used in the toolbox
* and the pre-loaded blocks. No duplicates.
* TODO(evd2014): Move pushBlockTypesToList to FactoryUtils.

View File

@@ -1,4 +1,4 @@
/*
/**
* Copyright (C) 2013 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");