CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-07 09:00:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix!: Remove alt+key commands (#8961)

Browse Source 
* fix: Remove the alt+key commands

* Remove tests for alt+key combos
This commit is contained in:
RoboErikG
2025-05-02 12:23:07 -07:00
committed by GitHub
parent dd3133baac
commit a4e6166ca8
2 changed files with 5 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
core/shortcut_items.ts
View File

@@ -99,9 +99,6 @@ export function registerCopy() {
const ctrlC = ShortcutRegistry.registry.createSerializedKey(KeyCodes.C, [ const ctrlC = ShortcutRegistry.registry.createSerializedKey(KeyCodes.C, [
KeyCodes.CTRL, KeyCodes.CTRL,
]); ]);
const altC = ShortcutRegistry.registry.createSerializedKey(KeyCodes.C, [
KeyCodes.ALT,
]);
const metaC = ShortcutRegistry.registry.createSerializedKey(KeyCodes.C, [ const metaC = ShortcutRegistry.registry.createSerializedKey(KeyCodes.C, [
KeyCodes.META, KeyCodes.META,
]); ]);
@@ -138,7 +135,7 @@ export function registerCopy() {
: null; : null;
return !!copyData; return !!copyData;
}, },
keyCodes: [ctrlC, altC, metaC], keyCodes: [ctrlC, metaC],
}; };
ShortcutRegistry.registry.register(copyShortcut); ShortcutRegistry.registry.register(copyShortcut);
} }
@@ -150,9 +147,6 @@ export function registerCut() {
const ctrlX = ShortcutRegistry.registry.createSerializedKey(KeyCodes.X, [ const ctrlX = ShortcutRegistry.registry.createSerializedKey(KeyCodes.X, [
KeyCodes.CTRL, KeyCodes.CTRL,
]); ]);
const altX = ShortcutRegistry.registry.createSerializedKey(KeyCodes.X, [
KeyCodes.ALT,
]);
const metaX = ShortcutRegistry.registry.createSerializedKey(KeyCodes.X, [ const metaX = ShortcutRegistry.registry.createSerializedKey(KeyCodes.X, [
KeyCodes.META, KeyCodes.META,
]); ]);
@@ -197,7 +191,7 @@ export function registerCut() {
} }
return false; return false;
}, },
keyCodes: [ctrlX, altX, metaX], keyCodes: [ctrlX, metaX],
}; };
ShortcutRegistry.registry.register(cutShortcut); ShortcutRegistry.registry.register(cutShortcut);
@@ -210,9 +204,6 @@ export function registerPaste() {
const ctrlV = ShortcutRegistry.registry.createSerializedKey(KeyCodes.V, [ const ctrlV = ShortcutRegistry.registry.createSerializedKey(KeyCodes.V, [
KeyCodes.CTRL, KeyCodes.CTRL,
]); ]);
const altV = ShortcutRegistry.registry.createSerializedKey(KeyCodes.V, [
KeyCodes.ALT,
]);
const metaV = ShortcutRegistry.registry.createSerializedKey(KeyCodes.V, [ const metaV = ShortcutRegistry.registry.createSerializedKey(KeyCodes.V, [
KeyCodes.META, KeyCodes.META,
]); ]);
@@ -245,7 +236,7 @@ export function registerPaste() {
const centerCoords = new Coordinate(left + width / 2, top + height / 2); const centerCoords = new Coordinate(left + width / 2, top + height / 2);
return !!clipboard.paste(copyData, copyWorkspace, centerCoords); return !!clipboard.paste(copyData, copyWorkspace, centerCoords);
}, },
keyCodes: [ctrlV, altV, metaV], keyCodes: [ctrlV, metaV],
}; };
ShortcutRegistry.registry.register(pasteShortcut); ShortcutRegistry.registry.register(pasteShortcut);
@@ -258,9 +249,6 @@ export function registerUndo() {
const ctrlZ = ShortcutRegistry.registry.createSerializedKey(KeyCodes.Z, [ const ctrlZ = ShortcutRegistry.registry.createSerializedKey(KeyCodes.Z, [
KeyCodes.CTRL, KeyCodes.CTRL,
]); ]);
const altZ = ShortcutRegistry.registry.createSerializedKey(KeyCodes.Z, [
KeyCodes.ALT,
]);
const metaZ = ShortcutRegistry.registry.createSerializedKey(KeyCodes.Z, [ const metaZ = ShortcutRegistry.registry.createSerializedKey(KeyCodes.Z, [
KeyCodes.META, KeyCodes.META,
]); ]);
@@ -277,7 +265,7 @@ export function registerUndo() {
e.preventDefault(); e.preventDefault();
return true; return true;
}, },
keyCodes: [ctrlZ, altZ, metaZ], keyCodes: [ctrlZ, metaZ],
}; };
ShortcutRegistry.registry.register(undoShortcut); ShortcutRegistry.registry.register(undoShortcut);
} }
@@ -291,10 +279,6 @@ export function registerRedo() {
KeyCodes.SHIFT, KeyCodes.SHIFT,
KeyCodes.CTRL, KeyCodes.CTRL,
]); ]);
const altShiftZ = ShortcutRegistry.registry.createSerializedKey(KeyCodes.Z, [
KeyCodes.SHIFT,
KeyCodes.ALT,
]);
const metaShiftZ = ShortcutRegistry.registry.createSerializedKey(KeyCodes.Z, [ const metaShiftZ = ShortcutRegistry.registry.createSerializedKey(KeyCodes.Z, [
KeyCodes.SHIFT, KeyCodes.SHIFT,
KeyCodes.META, KeyCodes.META,
@@ -316,7 +300,7 @@ export function registerRedo() {
e.preventDefault(); e.preventDefault();
return true; return true;
}, },
keyCodes: [ctrlShiftZ, altShiftZ, metaShiftZ, ctrlY], keyCodes: [ctrlShiftZ, metaShiftZ, ctrlY],
}; };
ShortcutRegistry.registry.register(redoShortcut); ShortcutRegistry.registry.register(redoShortcut);
} }

19
tests/mocha/keydown_test.js
View File

@@ -132,12 +132,6 @@ suite('Key Down', function () {
Blockly.utils.KeyCodes.META, Blockly.utils.KeyCodes.META,
]), ]),
], ],
[
'Alt C',
createKeyDownEvent(Blockly.utils.KeyCodes.C, [
Blockly.utils.KeyCodes.ALT,
]),
],
]; ];
// Copy a block. // Copy a block.
suite('Simple', function () { suite('Simple', function () {
@@ -223,12 +217,6 @@ suite('Key Down', function () {
Blockly.utils.KeyCodes.META, Blockly.utils.KeyCodes.META,
]), ]),
], ],
[
'Alt Z',
createKeyDownEvent(Blockly.utils.KeyCodes.Z, [
Blockly.utils.KeyCodes.ALT,
]),
],
]; ];
// Undo. // Undo.
suite('Simple', function () { suite('Simple', function () {
@@ -289,13 +277,6 @@ suite('Key Down', function () {
Blockly.utils.KeyCodes.SHIFT, Blockly.utils.KeyCodes.SHIFT,
]), ]),
], ],
[
'Alt Shift Z',
createKeyDownEvent(Blockly.utils.KeyCodes.Z, [
Blockly.utils.KeyCodes.ALT,
Blockly.utils.KeyCodes.SHIFT,
]),
],
]; ];
// Undo. // Undo.
suite('Simple', function () { suite('Simple', function () {