CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-07 09:00:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix 6 warnings related to generators. (#3293)

Browse Source
This commit is contained in:
Sam El-Husseini
2019-10-21 22:20:04 -04:00
committed by GitHub
parent c00ee908e4
commit a9cd25f2a4
1 changed files with 23 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
core/generator.js
View File

@@ -374,6 +374,28 @@ Blockly.Generator.prototype.addReservedWords = function(words) {
*/ */
Blockly.Generator.prototype.FUNCTION_NAME_PLACEHOLDER_ = '{leCUI8hutHZI4480Dc}'; Blockly.Generator.prototype.FUNCTION_NAME_PLACEHOLDER_ = '{leCUI8hutHZI4480Dc}';
/**
* A dictionary of definitions to be printed before the code.
* @type {Object}
* @protected
*/
Blockly.Generator.prototype.definitions_;
/**
* A dictionary mapping desired function names in definitions_ to actual
* function names (to avoid collisions with user functions).
* @type {Object}
* @protected
*/
Blockly.Generator.prototype.functionNames_;
/**
* A database of variable names.
* @type {Blockly.Names}
* @protected
*/
Blockly.Generator.prototype.variableDB_;
/** /**
* Define a function to be included in the generated code. * Define a function to be included in the generated code.
* The first time this is called with a given desiredName, the code is * The first time this is called with a given desiredName, the code is
@@ -394,7 +416,7 @@ Blockly.Generator.prototype.FUNCTION_NAME_PLACEHOLDER_ = '{leCUI8hutHZI4480Dc}';
Blockly.Generator.prototype.provideFunction_ = function(desiredName, code) { Blockly.Generator.prototype.provideFunction_ = function(desiredName, code) {
if (!this.definitions_[desiredName]) { if (!this.definitions_[desiredName]) {
var functionName = this.variableDB_.getDistinctName(desiredName, var functionName = this.variableDB_.getDistinctName(desiredName,
Blockly.Procedures.NAME_TYPE); Blockly.PROCEDURE_CATEGORY_NAME);
this.functionNames_[desiredName] = functionName; this.functionNames_[desiredName] = functionName;
var codeText = code.join('\n').replace( var codeText = code.join('\n').replace(
this.FUNCTION_NAME_PLACEHOLDER_REGEXP_, functionName); this.FUNCTION_NAME_PLACEHOLDER_REGEXP_, functionName);