From ab3bc6c3d89107b217149ef9df41a40768517848 Mon Sep 17 00:00:00 2001 From: Beka Westberg Date: Mon, 9 Oct 2023 10:34:06 -0700 Subject: [PATCH] fix: colour from colour picker not being updated (#7584) * fix: colour from colour picker not being updated * chore: clarify what code is doing --- core/field_colour.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/core/field_colour.ts b/core/field_colour.ts index de771c9af..6b78a2e50 100644 --- a/core/field_colour.ts +++ b/core/field_colour.ts @@ -246,12 +246,9 @@ export class FieldColour extends Field { const block = this.getSourceBlock() as BlockSvg | null; if (!block) throw new UnattachedFieldError(); - // In general, do *not* let fields control the color of blocks. Having the - // field control the color is unexpected, and could have performance - // impacts. - // Whenever we render, the field may no longer be a full-block-field so - // we need to update the colour. - if (this.getConstants()!.FIELD_COLOUR_FULL_BLOCK) block.applyColour(); + // Calling applyColour updates the UI (full-block vs non-full-block) for the + // colour field, and the colour of the field/block. + block.applyColour(); } /**