From abe4cf98f23dcc8a97dca0cae52b60790900af98 Mon Sep 17 00:00:00 2001 From: Beka Westberg Date: Wed, 7 Feb 2024 17:30:44 +0000 Subject: [PATCH] chore: fix v11 branch build (#7836) * chore: fix render management lint * fix: build --- core/render_management.ts | 2 +- scripts/gulpfiles/build_tasks.js | 4 ++-- tests/mocha/render_management_test.js | 2 ++ tests/typescript/src/generators.ts | 2 +- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/core/render_management.ts b/core/render_management.ts index 6b7e604f4..8a1d9407b 100644 --- a/core/render_management.ts +++ b/core/render_management.ts @@ -16,7 +16,7 @@ const rootBlocks = new Set(); const dirtyBlocks = new WeakSet(); /** A map from queued blocks to the event group from when they were queued. */ -let eventGroups = new WeakMap(); +const eventGroups = new WeakMap(); /** * The promise which resolves after the current set of renders is completed. Or diff --git a/scripts/gulpfiles/build_tasks.js b/scripts/gulpfiles/build_tasks.js index ca7f11073..8775f6918 100644 --- a/scripts/gulpfiles/build_tasks.js +++ b/scripts/gulpfiles/build_tasks.js @@ -208,8 +208,6 @@ const JSCOMP_ERROR = [ 'conformanceViolations', 'const', 'constantProperty', - 'deprecated', - 'deprecatedAnnotations', 'duplicateMessage', 'es5Strict', 'externsValidation', @@ -256,6 +254,8 @@ const JSCOMP_ERROR = [ * it's generally sufficient to remove them from JSCOMP_ERROR. */ const JSCOMP_WARNING = [ + 'deprecated', + 'deprecatedAnnotations', ]; /** diff --git a/tests/mocha/render_management_test.js b/tests/mocha/render_management_test.js index 7e22cfffb..7852a5b0c 100644 --- a/tests/mocha/render_management_test.js +++ b/tests/mocha/render_management_test.js @@ -74,6 +74,8 @@ suite('Render Management', function () { isDisposed: () => false, getRelativeToSurfaceXY: () => ({x: 0, y: 0}), updateComponentLocations: () => {}, + bumpNeighbours: () => {}, + initialized: true, workspace: ws || createMockWorkspace(), }; } diff --git a/tests/typescript/src/generators.ts b/tests/typescript/src/generators.ts index a87d70ee3..fd79a3a00 100644 --- a/tests/typescript/src/generators.ts +++ b/tests/typescript/src/generators.ts @@ -28,4 +28,4 @@ testGenerator.forBlock['test_block'] = function ( return ['a fake code string', Order.ADDITION]; }; -phpGenerator.quote_(); +phpGenerator.quote_('a string');