refactor(build): Delete Closure Library (#7415)

* fix(build): Restore erroneously-deleted filter function

  This was deleted in PR #7406 as it was mainly being used to
  filter core/ vs. test/mocha/ deps into separate deps files -
  but it turns out also to be used for filtering error
  messages too.  Oops.

* refactor(tests): Migrate advanced compilation test to ES Modules

* refactor(build): Migrate main.js to TypeScript

  This turns out to be pretty straight forward, even if it would
  cause crashing if one actually tried to import this module
  instead of just feeding it to Closure Compiler.

* chore(build): Remove goog.declareModuleId calls

  Replace goog.declareModuleId calls with a comment recording the
  former module ID for posterity (or at least until we decide
  how to reformat the renamings file.

* chore(tests): Delete closure/goog/*

  For the moment we still need something to serve as base.js for
  the benefit of closure-make-deps, so we keep a vestigial
  base.js around, containing only the @provideGoog declaration.

* refactor(build): Remove vestigial base.js

  By changing slightly the command line arguments to
  closure-make-deps and closure-calculate-chunks the need to have
  any base.js is eliminated.

* chore: Typo fix for PR #7415

generators/dart.js

@@ -10,8 +10,7 @@
  * @suppress {extraRequire}
  */
 
-import * as goog from '../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Dart.all');
+// Former goog.module ID: Blockly.Dart.all
 
 import {DartGenerator} from './dart/dart_generator.js';
 import * as colour from './dart/colour.js';

generators/dart/colour.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Dart for colour blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Dart.colour');
+// Former goog.module ID: Blockly.Dart.colour
 
 import {Order} from './dart_generator.js';
 

generators/dart/dart_generator.js

@@ -9,8 +9,7 @@
  * @suppress {checkTypes|globalThis}
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Dart');
+// Former goog.module ID: Blockly.Dart
 
 import * as Variables from '../../core/variables.js';
 import * as stringUtils from '../../core/utils/string.js';

generators/dart/lists.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Dart for list blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Dart.lists');
+// Former goog.module ID: Blockly.Dart.lists
 
 import {NameType} from '../../core/names.js';
 import {Order} from './dart_generator.js';

generators/dart/logic.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Dart for logic blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Dart.logic');
+// Former goog.module ID: Blockly.Dart.logic
 
 import {Order} from './dart_generator.js';
 

generators/dart/loops.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Dart for loop blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Dart.loops');
+// Former goog.module ID: Blockly.Dart.loops
 
 import {Order} from './dart_generator.js';
 import * as stringUtils from '../../core/utils/string.js';

generators/dart/math.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Dart for math blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Dart.math');
+// Former goog.module ID: Blockly.Dart.math
 
 import {NameType} from '../../core/names.js';
 import {Order} from './dart_generator.js';

generators/dart/procedures.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Dart for procedure blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Dart.procedures');
+// Former goog.module ID: Blockly.Dart.procedures
 
 import {NameType} from '../../core/names.js';
 import {Order} from './dart_generator.js';

generators/dart/text.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Dart for text blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Dart.texts');
+// Former goog.module ID: Blockly.Dart.texts
 
 import {NameType} from '../../core/names.js';
 import {Order} from './dart_generator.js';

generators/dart/variables.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Dart for variable blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Dart.variables');
+// Former goog.module ID: Blockly.Dart.variables
 
 import {NameType} from '../../core/names.js';
 import {Order} from './dart_generator.js';

generators/dart/variables_dynamic.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Dart for dynamic variable blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Dart.variablesDynamic');
+// Former goog.module ID: Blockly.Dart.variablesDynamic
 
 
 // generator is dynamically typed.

generators/javascript.js

@@ -10,8 +10,7 @@
  * @suppress {extraRequire}
  */
 
-import * as goog from '../closure/goog/goog.js';
-goog.declareModuleId('Blockly.JavaScript.all');
+// Former goog.module ID: Blockly.JavaScript.all
 
 import {JavascriptGenerator} from './javascript/javascript_generator.js';
 import * as colour from './javascript/colour.js';

generators/javascript/colour.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating JavaScript for colour blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.JavaScript.colour');
+// Former goog.module ID: Blockly.JavaScript.colour
 
 import {Order} from './javascript_generator.js';
 

generators/javascript/javascript_generator.js

@@ -9,8 +9,7 @@
  * @suppress {checkTypes|globalThis}
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.JavaScript');
+// Former goog.module ID: Blockly.JavaScript
 
 import * as Variables from '../../core/variables.js';
 import * as stringUtils from '../../core/utils/string.js';

generators/javascript/lists.js

@@ -9,8 +9,7 @@
  * @suppress {missingRequire}
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.JavaScript.lists');
+// Former goog.module ID: Blockly.JavaScript.lists
 
 import {NameType} from '../../core/names.js';
 import {Order} from './javascript_generator.js';

generators/javascript/logic.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating JavaScript for logic blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.JavaScript.logic');
+// Former goog.module ID: Blockly.JavaScript.logic
 
 import {Order} from './javascript_generator.js';
 

generators/javascript/loops.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating JavaScript for loop blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.JavaScript.loops');
+// Former goog.module ID: Blockly.JavaScript.loops
 
 import * as stringUtils from '../../core/utils/string.js';
 import {NameType} from '../../core/names.js';

generators/javascript/math.js

@@ -9,8 +9,7 @@
  * @suppress {missingRequire}
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.JavaScript.math');
+// Former goog.module ID: Blockly.JavaScript.math
 
 import {NameType} from '../../core/names.js';
 import {Order} from './javascript_generator.js';

generators/javascript/procedures.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating JavaScript for procedure blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.JavaScript.procedures');
+// Former goog.module ID: Blockly.JavaScript.procedures
 
 import {NameType} from '../../core/names.js';
 import {Order} from './javascript_generator.js';

generators/javascript/text.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating JavaScript for text blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.JavaScript.texts');
+// Former goog.module ID: Blockly.JavaScript.texts
 
 import {NameType} from '../../core/names.js';
 import {Order} from './javascript_generator.js';

generators/javascript/variables.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating JavaScript for variable blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.JavaScript.variables');
+// Former goog.module ID: Blockly.JavaScript.variables
 
 import {NameType} from '../../core/names.js';
 import {Order} from './javascript_generator.js';

generators/javascript/variables_dynamic.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating JavaScript for dynamic variable blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.JavaScript.variablesDynamic');
+// Former goog.module ID: Blockly.JavaScript.variablesDynamic
 
 
 // JavaScript is dynamically typed.

generators/lua.js

@@ -10,8 +10,7 @@
  * @suppress {extraRequire}
  */
 
-import * as goog from '../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Lua.all');
+// Former goog.module ID: Blockly.Lua.all
 
 import {LuaGenerator} from './lua/lua_generator.js';
 import * as colour from './lua/colour.js';

generators/lua/colour.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Lua for colour blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Lua.colour');
+// Former goog.module ID: Blockly.Lua.colour
 
 import {Order} from './lua_generator.js';
 

generators/lua/lists.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Lua for list blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Lua.lists');
+// Former goog.module ID: Blockly.Lua.lists
 
 import {NameType} from '../../core/names.js';
 import {Order} from './lua_generator.js';

generators/lua/logic.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Lua for logic blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Lua.logic');
+// Former goog.module ID: Blockly.Lua.logic
 
 import {Order} from './lua_generator.js';
 

generators/lua/loops.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Lua for loop blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Lua.loops');
+// Former goog.module ID: Blockly.Lua.loops
 
 import * as stringUtils from '../../core/utils/string.js';
 import {NameType} from '../../core/names.js';

generators/lua/lua_generator.js

@@ -10,8 +10,7 @@
  * @suppress {checkTypes|globalThis}
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Lua');
+// Former goog.module ID: Blockly.Lua
 
 import * as stringUtils from '../../core/utils/string.js';
 // import type {Block} from '../../core/block.js';

generators/lua/math.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Lua for math blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Lua.math');
+// Former goog.module ID: Blockly.Lua.math
 
 import {NameType} from '../../core/names.js';
 import {Order} from './lua_generator.js';

generators/lua/procedures.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Lua for procedure blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Lua.procedures');
+// Former goog.module ID: Blockly.Lua.procedures
 
 import {NameType} from '../../core/names.js';
 import {Order} from './lua_generator.js';

generators/lua/text.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Lua for text blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Lua.texts');
+// Former goog.module ID: Blockly.Lua.texts
 
 import {NameType} from '../../core/names.js';
 import {Order} from './lua_generator.js';

generators/lua/variables.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Lua for variable blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Lua.variables');
+// Former goog.module ID: Blockly.Lua.variables
 
 import {NameType} from '../../core/names.js';
 import {Order} from './lua_generator.js';

generators/lua/variables_dynamic.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Lua for dynamic variable blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Lua.variablesDynamic');
+// Former goog.module ID: Blockly.Lua.variablesDynamic
 
 
 // Lua is dynamically typed.

generators/php.js

@@ -10,8 +10,7 @@
  * @suppress {extraRequire}
  */
 
-import * as goog from '../closure/goog/goog.js';
-goog.declareModuleId('Blockly.PHP.all');
+// Former goog.module ID: Blockly.PHP.all
 
 import {PhpGenerator} from './php/php_generator.js';
 import * as colour from './php/colour.js';

generators/php/colour.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating PHP for colour blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.PHP.colour');
+// Former goog.module ID: Blockly.PHP.colour
 
 import {Order} from './php_generator.js';
 

generators/php/lists.js

@@ -19,8 +19,7 @@
  * ex:  end(true ? list1 : list2)
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.generator.lists');
+// Former goog.module ID: Blockly.generator.lists
 
 import * as stringUtils from '../../core/utils/string.js';
 import {NameType} from '../../core/names.js';

generators/php/logic.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating PHP for logic blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.PHP.logic');
+// Former goog.module ID: Blockly.PHP.logic
 
 import {Order} from './php_generator.js';
 

generators/php/loops.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating PHP for loop blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.PHP.loops');
+// Former goog.module ID: Blockly.PHP.loops
 
 import * as stringUtils from '../../core/utils/string.js';
 import {NameType} from '../../core/names.js';

generators/php/math.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating PHP for math blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.PHP.math');
+// Former goog.module ID: Blockly.PHP.math
 
 import {NameType} from '../../core/names.js';
 import {Order} from './php_generator.js';

generators/php/php_generator.js

@@ -9,8 +9,7 @@
  * @suppress {checkTypes|globalThis}
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.PHP');
+// Former goog.module ID: Blockly.PHP
 
 import * as stringUtils from '../../core/utils/string.js';
 // import type {Block} from '../../core/block.js';

generators/php/procedures.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating PHP for procedure blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.PHP.procedures');
+// Former goog.module ID: Blockly.PHP.procedures
 
 import * as Variables from '../../core/variables.js';
 import {NameType} from '../../core/names.js';

generators/php/text.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating PHP for text blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.PHP.texts');
+// Former goog.module ID: Blockly.PHP.texts
 
 import {NameType} from '../../core/names.js';
 import {Order} from './php_generator.js';

generators/php/variables.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating PHP for variable blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.PHP.variables');
+// Former goog.module ID: Blockly.PHP.variables
 
 import {NameType} from '../../core/names.js';
 import {Order} from './php_generator.js';

generators/php/variables_dynamic.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating PHP for dynamic variable blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.PHP.variablesDynamic');
+// Former goog.module ID: Blockly.PHP.variablesDynamic
 
 
 // generator is dynamically typed.

generators/python.js

@@ -10,8 +10,7 @@
  * @suppress {extraRequire}
  */
 
-import * as goog from '../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Python.all');
+// Former goog.module ID: Blockly.Python.all
 
 import {PythonGenerator} from './python/python_generator.js';
 import * as colour from './python/colour.js';

generators/python/colour.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Python for colour blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Python.colour');
+// Former goog.module ID: Blockly.Python.colour
 
 import {Order} from './python_generator.js';
 

generators/python/lists.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Python for list blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Python.lists');
+// Former goog.module ID: Blockly.Python.lists
 
 import * as stringUtils from '../../core/utils/string.js';
 import {NameType} from '../../core/names.js';

generators/python/logic.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Python for logic blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Python.logic');
+// Former goog.module ID: Blockly.Python.logic
 
 import {Order} from './python_generator.js';
 

generators/python/loops.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Python for loop blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Python.loops');
+// Former goog.module ID: Blockly.Python.loops
 
 import * as stringUtils from '../../core/utils/string.js';
 import {NameType} from '../../core/names.js';

generators/python/math.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Python for math blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Python.math');
+// Former goog.module ID: Blockly.Python.math
 
 import {NameType} from '../../core/names.js';
 import {Order} from './python_generator.js';

generators/python/procedures.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Python for procedure blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Python.procedures');
+// Former goog.module ID: Blockly.Python.procedures
 
 import * as Variables from '../../core/variables.js';
 import {NameType} from '../../core/names.js';

generators/python/python_generator.js

@@ -9,8 +9,7 @@
  * @suppress {checkTypes|globalThis}
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Python');
+// Former goog.module ID: Blockly.Python
 
 import * as stringUtils from '../../core/utils/string.js';
 import * as Variables from '../../core/variables.js';

generators/python/text.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Python for text blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Python.texts');
+// Former goog.module ID: Blockly.Python.texts
 
 import * as stringUtils from '../../core/utils/string.js';
 import {NameType} from '../../core/names.js';

generators/python/variables.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Python for variable blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Python.variables');
+// Former goog.module ID: Blockly.Python.variables
 
 import {NameType} from '../../core/names.js';
 import {Order} from './python_generator.js';

generators/python/variables_dynamic.js

@@ -8,8 +8,7 @@
  * @fileoverview Generating Python for dynamic variable blocks.
  */
 
-import * as goog from '../../closure/goog/goog.js';
-goog.declareModuleId('Blockly.Python.variablesDynamic');
+// Former goog.module ID: Blockly.Python.variablesDynamic
 
 
 // generator is dynamically typed.