From b7940fd1564a074428976be0d2deb098571f01e8 Mon Sep 17 00:00:00 2001
From: Emma Dauterman <evd2014@gmail.com>
Date: Fri, 26 Aug 2016 11:44:15 -0700
Subject: [PATCH] Blockly Factory: Shadow Block UI (#602)

* Fixed bug of open flyout not updating by closing flyout, also changed shadow block editing UI to be a block that changes between add shadow and remove shadow

* Removed unncessary CSS rule
---
 demos/blocklyfactory/factory.css              | 11 +++
 demos/blocklyfactory/index.html               | 11 +--
 .../workspacefactory/wfactory_controller.js   |  3 +
 .../workspacefactory/wfactory_init.js         | 94 ++++++++++---------
 4 files changed, 66 insertions(+), 53 deletions(-)

diff --git a/demos/blocklyfactory/factory.css b/demos/blocklyfactory/factory.css
index dad8922c3..6118816f0 100644
--- a/demos/blocklyfactory/factory.css
+++ b/demos/blocklyfactory/factory.css
@@ -467,6 +467,17 @@ td {
   margin-top: 2%;
 }
 
+#disable_div {
+  background-color: white;
+  height: 100%;
+  left: 0;
+  opacity: .5;
+  position: absolute;
+  top: 0;
+  width: 100%;
+  z-index: -1;  /* Start behind workspace */
+}
+
 /* Rules for Closure popup color picker */
 .goog-palette {
   outline: none;
diff --git a/demos/blocklyfactory/index.html b/demos/blocklyfactory/index.html
index 8a5e8fd23..6c5aadf5e 100644
--- a/demos/blocklyfactory/index.html
+++ b/demos/blocklyfactory/index.html
@@ -212,15 +212,8 @@
 
       </aside>
 
-      <div id="shadowBlockDropdown" class='dropdown'>
-      <button id="button_editShadow">Edit Block</button>
-      <div id="dropdownDiv_editShadowAdd" class="dropdown-content">
-        <a id='dropdown_addShadow'>Add Shadow</a>
-      </div>
-      <div id="dropdownDiv_editShadowRemove" class="dropdown-content">
-        <a id='dropdown_removeShadow'>Remove Shadow</a>
-      </div>
-      </div>
+      <button id='button_addShadow' style='display:none'>Make Shadow</button>
+      <button id='button_removeShadow' style='display:none'>Remove Shadow</button>
 
       <aside id='preload_div' style='display:none'>
         <div id="preloadHelp">
diff --git a/demos/blocklyfactory/workspacefactory/wfactory_controller.js b/demos/blocklyfactory/workspacefactory/wfactory_controller.js
index e663981c9..9e8a37655 100644
--- a/demos/blocklyfactory/workspacefactory/wfactory_controller.js
+++ b/demos/blocklyfactory/workspacefactory/wfactory_controller.js
@@ -423,6 +423,9 @@ WorkspaceFactoryController.prototype.updatePreview = function() {
       if (!this.previewWorkspace.toolbox_) {
         this.reinjectPreview(tree); // Create a toolbox, expensive.
       } else {
+        // Close the toolbox before updating it so that the user has to reopen
+        // the flyout and see their updated toolbox (open flyout doesn't update)
+        this.previewWorkspace.toolbox_.clearSelection();
         this.previewWorkspace.updateToolbox(tree);
       }
     }
diff --git a/demos/blocklyfactory/workspacefactory/wfactory_init.js b/demos/blocklyfactory/workspacefactory/wfactory_init.js
index 58209f0e0..db10c2163 100644
--- a/demos/blocklyfactory/workspacefactory/wfactory_init.js
+++ b/demos/blocklyfactory/workspacefactory/wfactory_init.js
@@ -47,7 +47,6 @@ WorkspaceFactoryInit.initWorkspaceFactory = function(controller) {
   document.getElementById('button_up').disabled = true;
   document.getElementById('button_down').disabled = true;
   document.getElementById('button_editCategory').disabled = true;
-  document.getElementById('button_editShadow').disabled = true;
 
   this.initColorPicker_(controller);
   this.addWorkspaceFactoryEventListeners_(controller);
@@ -258,34 +257,6 @@ WorkspaceFactoryInit.assignWorkspaceFactoryClickHandlers_ =
         toggle("show");
       });
 
-  document.getElementById('button_editShadow').addEventListener
-      ('click',
-      function() {
-        if (Blockly.selected) {
-          // Can only edit blocks when a block is selected.
-
-          if (!controller.isUserGenShadowBlock(Blockly.selected.id) &&
-              Blockly.selected.getSurroundParent() != null) {
-            // If a block is selected that could be a valid shadow block (not a
-            // shadow block, has a surrounding parent), let the user make it a
-            // shadow block. Use toggle instead of add so that the user can
-            // click the button again to make the dropdown disappear without
-            // clicking one of the options.
-            document.getElementById('dropdownDiv_editShadowRemove').classList.
-                remove("show");
-            document.getElementById('dropdownDiv_editShadowAdd').classList.
-                toggle("show");
-          } else {
-            // If the block is a shadow block, let the user make it a normal
-            // block.
-            document.getElementById('dropdownDiv_editShadowAdd').classList.
-                remove("show");
-            document.getElementById('dropdownDiv_editShadowRemove').classList.
-                toggle("show");
-          }
-        }
-      });
-
   document.getElementById('dropdown_name').addEventListener
       ('click',
       function() {
@@ -354,24 +325,25 @@ document.getElementById('button_importBlocks').addEventListener
         controller.clearAll();
       });
 
-  document.getElementById('dropdown_addShadow').addEventListener
+  document.getElementById('button_addShadow').addEventListener
       ('click',
       function() {
         controller.addShadow();
-        document.getElementById('dropdownDiv_editShadowAdd').classList.
-            remove("show");
+        WorkspaceFactoryInit.displayAddShadow_(false);
+        WorkspaceFactoryInit.displayRemoveShadow_(true);
       });
 
-  document.getElementById('dropdown_removeShadow').addEventListener
+  document.getElementById('button_removeShadow').addEventListener
       ('click',
       function() {
         controller.removeShadow();
-        document.getElementById('dropdownDiv_editShadowRemove').classList.
-            remove("show");
+        WorkspaceFactoryInit.displayAddShadow_(true);
+        WorkspaceFactoryInit.displayRemoveShadow_(false);
+
         // Disable shadow editing button if turning invalid shadow block back
         // to normal block.
         if (!Blockly.selected.getSurroundParent()) {
-          document.getElementById('button_editShadow').disabled = true;
+          document.getElementById('button_addShadow').disabled = true;
         }
       });
 
@@ -437,6 +409,18 @@ WorkspaceFactoryInit.addWorkspaceFactoryEventListeners_ = function(controller) {
         e.element == 'selected')) {
       var selected = Blockly.selected;
 
+      // Show shadow button if a block is selected. Show "Add Shadow" if
+      // a block is not a shadow block, show "Remove Shadow" if it is a
+      // shadow block.
+      if (selected) {
+        var isShadow = controller.isUserGenShadowBlock(selected.id);
+        WorkspaceFactoryInit.displayAddShadow_(!isShadow);
+        WorkspaceFactoryInit.displayRemoveShadow_(isShadow);
+      } else {
+        WorkspaceFactoryInit.displayAddShadow_(false);
+        WorkspaceFactoryInit.displayRemoveShadow_(false);
+      }
+
       if (selected != null && selected.getSurroundParent() != null &&
           !controller.isUserGenShadowBlock(selected.getSurroundParent().id)) {
         // Selected block is a valid shadow block or could be a valid shadow
@@ -444,7 +428,9 @@ WorkspaceFactoryInit.addWorkspaceFactoryEventListeners_ = function(controller) {
 
         // Enable block editing and remove warnings if the block is not a
         // variable user-generated shadow block.
-        document.getElementById('button_editShadow').disabled = false;
+        document.getElementById('button_addShadow').disabled = false;
+        document.getElementById('button_removeShadow').disabled = false;
+
         if (!FactoryUtils.hasVariableField(selected) &&
             controller.isDefinedBlock(selected)) {
           selected.setWarningText(null);
@@ -459,7 +445,7 @@ WorkspaceFactoryInit.addWorkspaceFactoryEventListeners_ = function(controller) {
 
           if (!controller.isUserGenShadowBlock(selected.id)) {
             // Warn if a non-shadow block is nested inside a shadow block.
-            selected.setWarningText('Only shadow blocks can be nested inside '
+            selected.setWarningText('Only shadow blocks can be nested inside\n'
                 + 'other shadow blocks.');
           } else if (!FactoryUtils.hasVariableField(selected)) {
             // Warn if a shadow block is invalid only if not replacing
@@ -470,7 +456,8 @@ WorkspaceFactoryInit.addWorkspaceFactoryEventListeners_ = function(controller) {
 
           // Give editing options so that the user can make an invalid shadow
           // block a normal block.
-          document.getElementById('button_editShadow').disabled = false;
+          document.getElementById('button_removeShadow').disabled = false;
+          document.getElementById('button_addShadow').disabled = true;
         } else {
           // Selected block does not break any shadow block rules, but cannot
           // be a shadow block.
@@ -484,11 +471,8 @@ WorkspaceFactoryInit.addWorkspaceFactoryEventListeners_ = function(controller) {
 
           // No block selected that is a shadow block or could be a valid shadow
           // block. Disable block editing.
-          document.getElementById('button_editShadow').disabled = true;
-          document.getElementById('dropdownDiv_editShadowRemove').classList.
-              remove("show");
-          document.getElementById('dropdownDiv_editShadowAdd').classList.
-              remove("show");
+          document.getElementById('button_addShadow').disabled = true;
+          document.getElementById('button_removeShadow').disabled = true;
         }
       }
     }
@@ -546,6 +530,28 @@ WorkspaceFactoryInit.addWorkspaceFactoryEventListeners_ = function(controller) {
   });
 };
 
+/**
+ * Display or hide the add shadow button.
+ *
+ * @param {boolean} show True if the add shadow button should be shown, false
+ *    otherwise.
+ */
+WorkspaceFactoryInit.displayAddShadow_ = function(show) {
+  document.getElementById('button_addShadow').style.display =
+      show ? 'inline-block' : 'none';
+};
+
+/**
+ * Display or hide the remove shadow button.
+ *
+ * @param {boolean} show True if the remove shadow button should be shown, false
+ *    otherwise.
+ */
+WorkspaceFactoryInit.displayRemoveShadow_ = function(show) {
+  document.getElementById('button_removeShadow').style.display =
+      show ? 'inline-block' : 'none';
+}
+
 /**
  * Add listeners for workspace factory options input elements.
  * @private