CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2025-12-16 06:10:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2751 from rachel-fenichel/eslint_rules

Browse Source 
Add more eslint rules
This commit is contained in:
Rachel Fenichel
2019-07-31 11:01:15 -07:00
committed by GitHub
parent 9466c6b7df 2d1179e52f
commit bc49bf849c
23 changed files with 38 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
.eslintrc.json
View File

@@ -54,8 +54,10 @@
"_comment": "Blockly uses single quotes except for JSON blobs, which must use double quotes.",
"quotes": ["off"],
"semi": ["error", "always"],
"_comment": "Blockly doesn't have space before function paren",
"_comment": "Blockly doesn't have space before function paren when defining functions",
"space-before-function-paren": ["error", "never"],
"_comment": "Blocklydoesn't have space before function paren when calling functions",
"func-call-spacing": ["error", "never"],
"space-infix-ops": ["error"],
"_comment": "Blockly uses 'use strict' in files",
"strict": ["off"],
@@ -64,7 +66,14 @@
"_comment": "Closure style allows redeclarations",
"no-redeclare": ["off"],
"valid-jsdoc": ["error", {"requireReturn": false}],
"no-console": ["off"]
"no-console": ["off"],
"no-multi-spaces": ["error", { "ignoreEOLComments": true }],
"operator-linebreak": ["error", "after"],
"spaced-comment": ["warn", "always", {
"block": {
"balanced": true
}
}]
},
"env": {
"browser": true

4
core/field_dropdown.js
View File

@@ -246,8 +246,8 @@ Blockly.FieldDropdown.prototype.positionMenu_ = function(menu) {
var menuSize = Blockly.utils.uiMenu.getSize(menu);
var menuMaxHeightPx = Blockly.FieldDropdown.MAX_MENU_HEIGHT_VH
* document.documentElement.clientHeight;
var menuMaxHeightPx = Blockly.FieldDropdown.MAX_MENU_HEIGHT_VH *
document.documentElement.clientHeight;
if (menuSize.height > menuMaxHeightPx) {
menuSize.height = menuMaxHeightPx;
}

4
core/trashcan.js
View File

@@ -405,8 +405,8 @@ Blockly.Trashcan.prototype.animateLid_ = function() {
* @private
*/
Blockly.Trashcan.prototype.setLidAngle_ = function(lidAngle) {
var openAtRight = this.workspace_.toolboxPosition == Blockly.TOOLBOX_AT_RIGHT
|| (this.workspace_.horizontalLayout && this.workspace_.RTL);
var openAtRight = this.workspace_.toolboxPosition == Blockly.TOOLBOX_AT_RIGHT ||
(this.workspace_.horizontalLayout && this.workspace_.RTL);
this.svgLid_.setAttribute('transform', 'rotate(' +
(openAtRight ? -lidAngle : lidAngle) + ',' +
(openAtRight ? 4 : this.WIDTH_ - 4) + ',' +

4
tests/mocha/connection_test.js
View File

@@ -7,8 +7,8 @@ suite('Connections', function() {
var connections = block.getConnections_(true);
for (var i = 0; i < connections.length; i++) {
var connection = connections[i];
if (connection.type == Blockly.PREVIOUS_STATEMENT
|| connection.type == Blockly.OUTPUT_VALUE) {
if (connection.type == Blockly.PREVIOUS_STATEMENT ||
connection.type == Blockly.OUTPUT_VALUE) {
// Only superior connections on inputs get hidden
continue;
}