From bcadd836b20dfac2f6c279267ba6e1573d878d81 Mon Sep 17 00:00:00 2001 From: Roy van Schaijk Date: Thu, 1 Aug 2019 20:14:52 +0200 Subject: [PATCH] Make the TabList exclude hidden fields (#2764) * Make the TabList exclude hidden fields * Stop using private variable --- core/block_svg.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/block_svg.js b/core/block_svg.js index 99dcc9cf1..cb8708cb7 100644 --- a/core/block_svg.js +++ b/core/block_svg.js @@ -605,7 +605,7 @@ Blockly.BlockSvg.prototype.createTabList_ = function() { var list = []; for (var i = 0, input; input = this.inputList[i]; i++) { for (var j = 0, field; field = input.fieldRow[j]; j++) { - if (field instanceof Blockly.FieldTextInput) { + if (field instanceof Blockly.FieldTextInput && field.isVisible()) { // TODO (#1276): Also support dropdown fields. list.push(field); }