CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-08 01:20:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

chore(deps): Bump chai from 4.3.10 to 5.1.1 (#8092)

Browse Source 
* chore(deps): Bump chai from 4.3.10 to 5.1.1

  Bumps [chai](https://github.com/chaijs/chai) from 4.3.10 to 5.1.1.
  - [Release notes](https://github.com/chaijs/chai/releases)
  - [Changelog](https://github.com/chaijs/chai/blob/main/History.md)
  - [Commits](https://github.com/chaijs/chai/compare/v4.3.10...v5.1.1)

  ---
  updated-dependencies:
  - dependency-name: chai
    dependency-type: direct:development
    update-type: version-update:semver-major
  ...

  Signed-off-by: dependabot[bot] <support@github.com>

* fix(tests): Migrate all usage of chai to ESM (#8216)

* fix(tests): Migrate node tests from CJS to ESM

  This allows us to import (rather than require) chai, fixing failures
  caused by that package dropping suppport for CJS in chai v5.0.0.

* fix(tests): Have mocha tests directly import chai

  Previously they relied on obtaining it from the global scope, but it's
  better if imports are explicit.

* fix(tests): Remove broken load of chai as script

  Chai v5.0.0 no longer supports being loaded as a script, so this did
  nothing but emit an syntax error message on the console.

* fix(tests): Migrate browser tests from CJS to ESM

  This allows us to import (rather than require) chai, fixing failures
  caused by chai no longer supporting CJS.

* chore(tests): format

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Christopher Allen <cpcallen+git@google.com>
This commit is contained in:
dependabot[bot]
2024-06-17 16:48:21 +01:00
committed by GitHub
parent 3fa46f45fe
commit bfb5b1dd49
112 changed files with 2419 additions and 2619 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
tests/mocha/comment_view_test.js
View File

@@ -4,6 +4,7 @@
* SPDX-License-Identifier: Apache-2.0
*/
import {assert} from '../../node_modules/chai/chai.js';
import {
sharedTestSetup,
sharedTestTeardown,
@@ -28,11 +29,8 @@ suite('Workspace comment', function () {
this.commentView.setText('test');
chai.assert.isTrue(
spy.calledOnce,
'Expected the spy to be called once',
);
chai.assert.isTrue(
assert.isTrue(spy.calledOnce, 'Expected the spy to be called once');
assert.isTrue(
spy.calledWith('', 'test'),
'Expected the spy to be called with the given args',
);
@@ -50,15 +48,15 @@ suite('Workspace comment', function () {
this.commentView.setText('test');
chai.assert.isTrue(
assert.isTrue(
fake1.calledOnce,
'Expected the first listener to be called',
);
chai.assert.isTrue(
assert.isTrue(
fake2.calledOnce,
'Expected the second listener to be called',
);
chai.assert.isTrue(
assert.isTrue(
fake3.calledOnce,
'Expected the third listener to be called',
);
@@ -74,11 +72,8 @@ suite('Workspace comment', function () {
this.commentView.setSize(newSize);
chai.assert.isTrue(
spy.calledOnce,
'Expected the spy to be called once',
);
chai.assert.isTrue(
assert.isTrue(spy.calledOnce, 'Expected the spy to be called once');
assert.isTrue(
spy.calledWith(originalSize, newSize),
'Expected the spy to be called with the given args',
);
@@ -97,15 +92,15 @@ suite('Workspace comment', function () {
this.commentView.setSize(newSize);
chai.assert.isTrue(
assert.isTrue(
fake1.calledOnce,
'Expected the first listener to be called',
);
chai.assert.isTrue(
assert.isTrue(
fake2.calledOnce,
'Expected the second listener to be called',
);
chai.assert.isTrue(
assert.isTrue(
fake3.calledOnce,
'Expected the third listener to be called',
);
@@ -119,11 +114,8 @@ suite('Workspace comment', function () {
this.commentView.setCollapsed(true);
chai.assert.isTrue(
spy.calledOnce,
'Expected the spy to be called once',
);
chai.assert.isTrue(
assert.isTrue(spy.calledOnce, 'Expected the spy to be called once');
assert.isTrue(
spy.calledWith(true),
'Expected the spy to be called with the given args',
);
@@ -141,15 +133,15 @@ suite('Workspace comment', function () {
this.commentView.setCollapsed(true);
chai.assert.isTrue(
assert.isTrue(
fake1.calledOnce,
'Expected the first listener to be called',
);
chai.assert.isTrue(
assert.isTrue(
fake2.calledOnce,
'Expected the second listener to be called',
);
chai.assert.isTrue(
assert.isTrue(
fake3.calledOnce,
'Expected the third listener to be called',
);
@@ -163,10 +155,7 @@ suite('Workspace comment', function () {
this.commentView.dispose();
chai.assert.isTrue(
spy.calledOnce,
'Expected the spy to be called once',
);
assert.isTrue(spy.calledOnce, 'Expected the spy to be called once');
});
test('dispose listeners can remove themselves without skipping others', function () {
@@ -181,15 +170,15 @@ suite('Workspace comment', function () {
this.commentView.dispose();
chai.assert.isTrue(
assert.isTrue(
fake1.calledOnce,
'Expected the first listener to be called',
);
chai.assert.isTrue(
assert.isTrue(
fake2.calledOnce,
'Expected the second listener to be called',
);
chai.assert.isTrue(
assert.isTrue(
fake3.calledOnce,
'Expected the third listener to be called',
);