Throw errors instead of strings. (#1974)

Blocks and generators
This commit is contained in:
Neil Fraser
2018-07-16 16:33:44 -07:00
committed by GitHub
parent 99ebefa1bf
commit c8bfc888c8
23 changed files with 55 additions and 55 deletions

View File

@@ -170,7 +170,7 @@ Blockly.JavaScript['lists_getIndex'] = function(block) {
}
break;
}
throw 'Unhandled combination (lists_getIndex).';
throw Error('Unhandled combination (lists_getIndex).');
};
Blockly.JavaScript['lists_setIndex'] = function(block) {
@@ -247,7 +247,7 @@ Blockly.JavaScript['lists_setIndex'] = function(block) {
}
break;
}
throw 'Unhandled combination (lists_setIndex).';
throw Error('Unhandled combination (lists_setIndex).');
};
/**
@@ -295,7 +295,7 @@ Blockly.JavaScript['lists_getSublist'] = function(block) {
var at1 = '0';
break;
default:
throw 'Unhandled option (lists_getSublist).';
throw Error('Unhandled option (lists_getSublist).');
}
switch (where2) {
case 'FROM_START':
@@ -310,7 +310,7 @@ Blockly.JavaScript['lists_getSublist'] = function(block) {
var at2 = list + '.length';
break;
default:
throw 'Unhandled option (lists_getSublist).';
throw Error('Unhandled option (lists_getSublist).');
}
code = list + '.slice(' + at1 + ', ' + at2 + ')';
} else {
@@ -387,7 +387,7 @@ Blockly.JavaScript['lists_split'] = function(block) {
}
var functionName = 'join';
} else {
throw 'Unknown mode: ' + mode;
throw Error('Unknown mode: ' + mode);
}
var code = input + '.' + functionName + '(' + delimiter + ')';
return [code, Blockly.JavaScript.ORDER_FUNCTION_CALL];